Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use proper exit code for composer lint #2267

Merged
merged 1 commit into from
May 14, 2020

Conversation

MorrisJobke
Copy link
Member

@MorrisJobke MorrisJobke requested a review from georgehrke May 13, 2020 20:49
@codecov-io
Copy link

codecov-io commented May 13, 2020

Codecov Report

Merging #2267 into master will decrease coverage by 66.75%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             master    #2267       +/-   ##
=============================================
- Coverage     94.41%   27.66%   -66.76%     
  Complexity      103      103               
=============================================
  Files             7      143      +136     
  Lines           394     5281     +4887     
  Branches          0      797      +797     
=============================================
+ Hits            372     1461     +1089     
- Misses           22     3820     +3798     
Flag Coverage Δ Complexity Δ
#javascript 22.28% <ø> (?) 0.00 <ø> (?)
#php 94.41% <ø> (ø) 103.00 <ø> (ø)
Impacted Files Coverage Δ Complexity Δ
src/fullcalendar/eventOrder.js 100.00% <0.00%> (ø) 0.00% <0.00%> (?%)
src/main.js 0.00% <0.00%> (ø) 0.00% <0.00%> (?%)
src/components/Editor/Repeat/RepeatSummary.vue 0.00% <0.00%> (ø) 0.00% <0.00%> (?%)
.../CalendarList/CalendarListItemSharingShareItem.vue 0.00% <0.00%> (ø) 0.00% <0.00%> (?%)
src/utils/logger.js 85.71% <0.00%> (ø) 0.00% <0.00%> (?%)
src/fullcalendar/eventClick.js 100.00% <0.00%> (ø) 0.00% <0.00%> (?%)
src/fullcalendar/eventSourceFunction.js 95.91% <0.00%> (ø) 0.00% <0.00%> (?%)
src/components/AppNavigation/Settings.vue 0.00% <0.00%> (ø) 0.00% <0.00%> (?%)
src/store/calendarObjects.js 0.00% <0.00%> (ø) 0.00% <0.00%> (?%)
src/models/contact.js 100.00% <0.00%> (ø) 0.00% <0.00%> (?%)
... and 126 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a37a99...74901a8. Read the comment docs.

@georgehrke georgehrke merged commit 36d0433 into master May 14, 2020
@georgehrke georgehrke deleted the fix/noid/composer-lint-command-exit-code branch May 14, 2020 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants