Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buttons should use material-design-icons #11

Open
raimund-schluessler opened this issue Nov 24, 2021 · 0 comments
Open

Buttons should use material-design-icons #11

raimund-schluessler opened this issue Nov 24, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@raimund-schluessler
Copy link
Member

The buttons here

<button :key="`slot-${day.id}-${idx}-btn`"
class="icon-delete delete-slot button"
:title="l10nDeleteSlot"
@click="removeSlot(day, idx)" />

and here
<button :key="`add-slot-${day.id}`"
:disabled="loading"
class="icon-add add-another button"
:title="l10nAddSlot"
@click="addSlot(day)" />

should use material-design icons to be in line with the rest of the Calendar app.

Since the new button component from nextcloud/vue@5 is not released yet, one option would be to use ActionButton instead. Similar to how it is done in the trash bin:
https://github.com/nextcloud/calendar/blob/master/src/components/AppNavigation/CalendarList/Trashbin.vue#L88-L96

@raimund-schluessler raimund-schluessler added the enhancement New feature or request label Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant