add types for missing ones and bring psalm-baseline down to zero #1645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szaimen
force-pushed
the
enh/noid/add-types
branch
from
d983354 to
ad0cf67
Compare
szaimen
commented
Jan 2, 2023
Signed-off-by: Simon L <[email protected]>
szaimen
force-pushed
the
enh/noid/add-types
branch
from
ad0cf67 to
8089ab8
Compare
szaimen
added
3. to review
33 tasks
szaimen
changed the title
come-nc
requested changes
Jan 2, 2023
There was a problem hiding this comment.
I think $args should be array: https://www.slimframework.com/docs/v4/objects/routing.html#route-callbacks
php/public/index.php
Outdated
| @@ -140,7 +142,7 @@ | |||
| }); | |||
|
|
|||
| // Auth Redirector | |||
| $app->get('/', function (\Psr\Http\Message\RequestInterface $request, \Psr\Http\Message\ResponseInterface $response, $args) use ($container) { | |||
| $app->get('/', function (\Psr\Http\Message\RequestInterface $request, Response $response, mixed $args) use ($container) { | |||
There was a problem hiding this comment.
Suggested change
| $app->get('/', function (\Psr\Http\Message\RequestInterface $request, Response $response, mixed $args) use ($container) { | |
| $app->get('/', function (Request $request, Response $response, mixed $args) use ($container) { |
consistency
There was a problem hiding this comment.
No, RequestInterface should be correct IIRC... (It is not a ServerRequest but a Client-Side request IIRC)...
There was a problem hiding this comment.
Name is misleading then, maybe import both as Request and ServerRequest to avoid the confusion.
There was a problem hiding this comment.
sorry, saw this too late
Signed-off-by: Simon L <[email protected]>
Thanks for figuring this out! Fixed :) |
juliusknorr
approved these changes
Jan 2, 2023
come-nc
approved these changes
Jan 2, 2023
|
Thanks a lot guys! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Simon L [email protected]