-
Notifications
You must be signed in to change notification settings - Fork 704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finish talk-recording geckodriver install or use chromium #2676
Comments
can I improve it a bit? |
Of course :) |
btw, I would wait with the request to move it out of testing until we actually confirmed that it works ... |
Possibly we could alternatively as soon as chromium support comes with nextcloud/spreed#9174 switch to that... |
are there differences between chromium and firefox? |
I don't know honestly... Possibly RAM and CPU usage could be different... |
This comment was marked as resolved.
This comment was marked as resolved.
Apparently the logs are unrelated. The recording worked nonetheless. But it was not automatically shared into the conversation, I only got a notification. |
Does not work |
so it works? |
yes :) |
do you now create the issue on the aports?? |
Ah yes, almost forgot |
The issue was closed... |
I would say lets wait for nextcloud/spreed#9174 to be merged and released. Then update the container to use chromium. If this works, I would say maintaining upstream geckodriver is not needed. If we cannot make it work with chromium then we can think about further steps. And thanks for the huge offer to take over the maintance of geckodriver btw! :) |
It seem there are some blockers for using chromium: nextcloud/spreed#9177 (comment) |
it's now merged ;-) |
While chromium recording is there, it is not the recommended solution |
I see. In that case, @Zoey2936, you offered a few comments above that you could take over the maintainership of the geckodriver package in alpine aports. Is that still the case? |
yes |
@szaimen can you please change the apk add line? |
Will it be already available now or do we need to wait e.g. for Alpine 3.19.1? |
I think 3.20.0 |
Okay, then I'd say lets wait for that |
Yes but it moved from testing to community, so this needs to be changed in the apk add line |
Okay, so we can already change that now or do we still need to wait for 3.19.1 for this to become available? |
We still need to pull it from edge, but from the community branch now |
alpine v3.20.1 was released |
Nice :) |
This is now released with v9.1.0 Beta. Testing and feedback is welcome! See https://github.com/nextcloud/all-in-one#how-to-switch-the-channel |
Things that should be done after #2645 is finished
test if using the internal signaling IP also worksdoes not worktry if chromium works after Chromium recording spreed#9174. If not, see below (should be available with 28)not recommendedgeckodriver:
apk add repository edge/testing
toapk add repository edge/community
talk-recording - pull geckodriver from community #3907apk add
line and removeapk add repository edge/community
lineThe text was updated successfully, but these errors were encountered: