Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to add exclude list for v-click-outside #983

Merged
merged 1 commit into from
Aug 7, 2020

Conversation

georgehrke
Copy link
Contributor

@georgehrke georgehrke commented Apr 2, 2020

fixes #862

Example: nextcloud/calendar#2155

@georgehrke georgehrke force-pushed the feature/862/custom_vclickoutside_handler branch 2 times, most recently from 815025f to 5b7978f Compare April 7, 2020 08:36
@georgehrke georgehrke marked this pull request as ready for review April 7, 2020 08:36
@georgehrke georgehrke added the 3. to review Waiting for reviews label Apr 7, 2020
@georgehrke georgehrke requested a review from skjnldsv April 7, 2020 08:37
@georgehrke
Copy link
Contributor Author

npm ERR! enoent ENOENT: no such file or directory, open '/home/runner/work/nextcloud-vue/nextcloud-vue/node_modules/fsevents/node_modules/detect-libc/package.json'

Fun ...

@skjnldsv
Copy link
Contributor

skjnldsv commented Apr 7, 2020

Fun ...

yeah, there is a weird thing going on, just reload the tests

@georgehrke
Copy link
Contributor Author

@skjnldsv Is this what you meant in #862 (comment)? :)

@skjnldsv
Copy link
Contributor

skjnldsv commented Apr 7, 2020

@skjnldsv Is this what you meant in #862 (comment)? :)

Yes, looks great!
Works fine? Should we allow to provide something else than a class? cc @ChristophWurst & @juliushaertl

@ChristophWurst
Copy link
Contributor

Works fine? Should we allow to provide something else than a class? cc @ChristophWurst & @juliushaertl

I'd say this is typically static, so a list of strings is fine.

@georgehrke
Copy link
Contributor Author

also cc @nickvergessen to check if this covers your use case :)

@nickvergessen
Copy link
Contributor

Maybe @ma12-co can judge better? The settings menu of the navigation should stay open when navigating throught the file picker when selecting the talk upload folder.

@skjnldsv skjnldsv added the enhancement New feature or request label Apr 22, 2020
@nickvergessen nickvergessen removed their request for review April 22, 2020 10:50
@marcoambrosini
Copy link
Contributor

Maybe @ma12-co can judge better? The settings menu of the navigation should stay open when navigating throught the file picker when selecting the talk upload folder.

It should probably stay open until the next click outside i think. I.e. not close upon clicking "choose".

@georgehrke
Copy link
Contributor Author

It should probably stay open until the next click outside i think. I.e. not close upon clicking "choose".

Can you give an example of what you mean (for Talk?)

@marcoambrosini
Copy link
Contributor

marcoambrosini commented Jun 29, 2020

Nevermind @georgehrke, we're going to move soon to a design similar to what mail has for our talk global settings

@skjnldsv
Copy link
Contributor

skjnldsv commented Aug 6, 2020

@georgehrke what is missing? :)

@georgehrke
Copy link
Contributor Author

I was mostly waiting for feedback from @nickvergessen and @ma12-co

Let me rebase and fix the linting issues.

@georgehrke
Copy link
Contributor Author

Nevermind @georgehrke, we're going to move soon to a design similar to what mail has for our talk global settings

Is there already an issue for this btw?

We also want to use that approach in the calendar, so it would be really helpful to just implement it in nc/vue.

@georgehrke georgehrke force-pushed the feature/862/custom_vclickoutside_handler branch from 5b7978f to 5f347bb Compare August 6, 2020 08:39
@georgehrke
Copy link
Contributor Author

npm ERR! 404 Not Found - GET https://registry.npmjs.org/@nextcloud/axios/-/axios-1.3.3.tgz
npm ERR! 404
npm ERR! 404 '@nextcloud/[email protected]' is not in the npm registry.

🙃

@georgehrke
Copy link
Contributor Author

Now it's failing with another random package. I guess its best to just wait half an hour ...

@skjnldsv
Copy link
Contributor

skjnldsv commented Aug 6, 2020

https://status.npmjs.org/

Update - The ongoing issue may also affect installation of scoped packages. We continue investigating these issues.
Aug 6, 08:55 UTC
Update - We are continuing to investigate this issue.
Aug 6, 08:29 UTC
Investigating - We are investigating reports of issues when accessing the npmjs.com website.
Aug 6, 08:29 UTC

@skjnldsv skjnldsv merged commit 0c34368 into master Aug 7, 2020
@skjnldsv skjnldsv deleted the feature/862/custom_vclickoutside_handler branch August 7, 2020 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AppNavigationSettings automatically close on "click outside"
6 participants