-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to add exclude list for v-click-outside #983
Conversation
815025f
to
5b7978f
Compare
Fun ... |
yeah, there is a weird thing going on, just reload the tests |
@skjnldsv Is this what you meant in #862 (comment)? :) |
Yes, looks great! |
I'd say this is typically static, so a list of strings is fine. |
also cc @nickvergessen to check if this covers your use case :) |
Maybe @ma12-co can judge better? The settings menu of the navigation should stay open when navigating throught the file picker when selecting the talk upload folder. |
It should probably stay open until the next click outside i think. I.e. not close upon clicking "choose". |
Can you give an example of what you mean (for Talk?) |
Nevermind @georgehrke, we're going to move soon to a design similar to what mail has for our talk global settings |
@georgehrke what is missing? :) |
I was mostly waiting for feedback from @nickvergessen and @ma12-co Let me rebase and fix the linting issues. |
Is there already an issue for this btw? We also want to use that approach in the calendar, so it would be really helpful to just implement it in nc/vue. |
Signed-off-by: Georg Ehrke <[email protected]>
5b7978f
to
5f347bb
Compare
🙃 |
Now it's failing with another random package. I guess its best to just wait half an hour ... |
Update - The ongoing issue may also affect installation of scoped packages. We continue investigating these issues.
Aug 6, 08:55 UTC
Update - We are continuing to investigate this issue.
Aug 6, 08:29 UTC
Investigating - We are investigating reports of issues when accessing the npmjs.com website.
Aug 6, 08:29 UTC |
fixes #862
Example: nextcloud/calendar#2155