Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use babel env usage & corejs@3 #749

Merged
merged 1 commit into from
Nov 27, 2019
Merged

Use babel env usage & corejs@3 #749

merged 1 commit into from
Nov 27, 2019

Conversation

skjnldsv
Copy link
Contributor

@skjnldsv skjnldsv commented Nov 27, 2019

closes #692
Fixes #691

Tested on guests with this branch
Capture d’écran_2019-11-27_12-56-23

@skjnldsv skjnldsv marked this pull request as ready for review November 27, 2019 11:57
@skjnldsv skjnldsv self-assigned this Nov 27, 2019
@skjnldsv skjnldsv added 3. to review Waiting for reviews bug Something isn't working configuration high High priority labels Nov 27, 2019
@skjnldsv skjnldsv added this to the 1.2.1 milestone Nov 27, 2019
Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>
Copy link
Contributor

@georgehrke georgehrke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes the privacy app-related issues i had this morning.

Module not found: Error: Can't resolve '@babel/runtime/helpers/asyncToGenerator' in '/Users/georgehrke/Development/Projects/Nextcloud/apps/privacy/node_modules/@nextcloud/vue/dist/Components' is gone.

Copy link
Contributor

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay

@ChristophWurst ChristophWurst merged commit 52f3f78 into master Nov 27, 2019
@delete-merged-branch delete-merged-branch bot deleted the fix/babel branch November 27, 2019 13:42
@raimund-schluessler
Copy link
Contributor

Works great, thanks. nextcloud/tasks#688 is in now. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working high High priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Babel modules not found
5 participants