Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(provider): added options in instagram provider #1570

Merged
merged 1 commit into from
Mar 23, 2021

Conversation

shkshubham
Copy link
Contributor

@shkshubham shkshubham commented Mar 23, 2021

What: No clientId in instagram url.

Why: In the Instagram provider, the URL was not taking clientId as we are not adding passed options to the object.

How: By spreading the options object

Checklist:

  • Documentation
  • Tests
  • Ready to be merged

@vercel
Copy link

vercel bot commented Mar 23, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nextauthjs/next-auth/CtcYiaSceN4D8YxKWXPKyYxCz5XD
✅ Preview: https://next-auth-git-fork-shkshubham-fix-instagram-provider-nextauthjs.vercel.app

@vercel vercel bot temporarily deployed to Preview March 23, 2021 21:12 Inactive
@github-actions github-actions bot added core Refers to `@auth/core` providers labels Mar 23, 2021
Copy link
Member

@balazsorban44 balazsorban44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦‍♂️ I think this was my mistake. Thanks for catching and providing a fix!

@balazsorban44 balazsorban44 merged commit e6d0638 into nextauthjs:main Mar 23, 2021
@github-actions
Copy link

🎉 This PR is included in version 3.13.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

viniciuscr pushed a commit to viniciuscr/next-auth that referenced this pull request Apr 9, 2021
@github-actions
Copy link

🎉 This PR is included in version 4.0.0-next.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

mnphpexpert added a commit to mnphpexpert/next-auth that referenced this pull request Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Refers to `@auth/core` providers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants