Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(provider): add Zoho provider #1516

Merged
merged 4 commits into from
Mar 16, 2021

Conversation

jkwiz
Copy link
Contributor

@jkwiz jkwiz commented Mar 13, 2021

What: I'm working on a project with Zoho so I figured I would contribute to the library.

Why: Others may find it helpful if they also use Zoho.

How: Following the documentation and examples to add a provider.

Checklist:

  • Documentation
  • Tests N/A
  • Ready to be merged

@vercel
Copy link

vercel bot commented Mar 13, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nextauthjs/next-auth/J2r9f5H3qSmyFWpZxSrWz1HuWQxg
✅ Preview: https://next-auth-git-fork-jkwiz-feat-zoho-provider-nextauthjs.vercel.app

@github-actions github-actions bot added core Refers to `@auth/core` docs Relates to documentation providers labels Mar 13, 2021
@balazsorban44 balazsorban44 changed the title feat(provider): add zoho feat(provider): add Zoho provider Mar 15, 2021
@@ -0,0 +1,26 @@
---
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So there seems to be a very strange issue here. Our script that should generate some of the docs reads these .md files with some RegEx to extract the title and id. Since this file was created on Windows, newline sequences are created as CRLF, in contrast to what our regex reads (LF).

I kindly ask you to commit this file with LF formatting, so our build can succeed:

image

We should probably improve the script here https://github.com/nextauthjs/next-auth/blob/main/www/scripts/generate-providers.js to not to trip up in the future.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick review. I was wondering why the build failed 🙂

I've committed this change and it appears to be passing.

@vercel vercel bot temporarily deployed to Preview March 16, 2021 13:21 Inactive
Copy link
Member

@balazsorban44 balazsorban44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@balazsorban44 balazsorban44 merged commit 776b948 into nextauthjs:main Mar 16, 2021
@github-actions
Copy link

🎉 This PR is included in version 3.13.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

🎉 This PR is included in version 4.0.0-next.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

@jkwiz jkwiz deleted the feat/zoho-provider branch May 8, 2021 14:15
mnphpexpert added a commit to mnphpexpert/next-auth that referenced this pull request Sep 2, 2024
* feat(provider): add zoho

* fix: use LF instead of CRLF

* fix: crlf to lf line endings

Co-authored-by: Balázs Orbán <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Refers to `@auth/core` docs Relates to documentation providers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants