-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(provider): add Zoho provider #1516
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/nextauthjs/next-auth/J2r9f5H3qSmyFWpZxSrWz1HuWQxg |
www/docs/providers/zoho.md
Outdated
@@ -0,0 +1,26 @@ | |||
--- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So there seems to be a very strange issue here. Our script that should generate some of the docs reads these .md files with some RegEx to extract the title and id. Since this file was created on Windows, newline sequences are created as CRLF, in contrast to what our regex reads (LF).
I kindly ask you to commit this file with LF formatting, so our build can succeed:
We should probably improve the script here https://github.com/nextauthjs/next-auth/blob/main/www/scripts/generate-providers.js to not to trip up in the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the quick review. I was wondering why the build failed 🙂
I've committed this change and it appears to be passing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks!
🎉 This PR is included in version 3.13.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 4.0.0-next.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
* feat(provider): add zoho * fix: use LF instead of CRLF * fix: crlf to lf line endings Co-authored-by: Balázs Orbán <[email protected]>
What: I'm working on a project with Zoho so I figured I would contribute to the library.
Why: Others may find it helpful if they also use Zoho.
How: Following the documentation and examples to add a provider.
Checklist: