Skip to content

Commit f546e55

Browse files
authored
fix(oauth): correctly remove code_verifier cookie when used (#2325)
Co-authored-by: Pol Bonastre <[email protected]>
1 parent ac5b4db commit f546e55

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

src/server/lib/oauth/pkce-handler.js

+5-1
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,11 @@ export async function handleCallback (req, res) {
3636
pkceLength: PKCE_LENGTH,
3737
method: PKCE_CODE_CHALLENGE_METHOD
3838
})
39-
cookie.set(res, cookies.pkceCodeVerifier.name, null, { maxAge: 0 }) // remove PKCE after it has been used
39+
// remove PKCE after it has been used
40+
cookie.set(res, cookies.pkceCodeVerifier.name, "", {
41+
...cookies.pkceCodeVerifier.options,
42+
maxAge: 0
43+
})
4044
} catch (error) {
4145
logger.error('CALLBACK_OAUTH_ERROR', error)
4246
return res.redirect(`${baseUrl}${basePath}/error?error=OAuthCallback`)

0 commit comments

Comments
 (0)