From 6911868cff9c52132716b5ebd4c2c3563c43ce1c Mon Sep 17 00:00:00 2001 From: Xin00163 Date: Tue, 17 Jan 2023 14:13:41 +0000 Subject: [PATCH 1/2] feat(PPDSC-2696): remove padding block from breadCrumbItem --- .../__tests__/__snapshots__/breadcrumbs.test.tsx.snap | 11 +++++++++++ src/breadcrumbs/defaults.ts | 3 +++ src/theme/__tests__/__snapshots__/theme.test.ts.snap | 3 +++ 3 files changed, 17 insertions(+) diff --git a/src/breadcrumbs/__tests__/__snapshots__/breadcrumbs.test.tsx.snap b/src/breadcrumbs/__tests__/__snapshots__/breadcrumbs.test.tsx.snap index c0d0f7a7af..264ab2bb30 100644 --- a/src/breadcrumbs/__tests__/__snapshots__/breadcrumbs.test.tsx.snap +++ b/src/breadcrumbs/__tests__/__snapshots__/breadcrumbs.test.tsx.snap @@ -50,6 +50,7 @@ exports[`BreadcrumbItem renders selected menu item with aria attributes 1`] = ` min-width: 80px; min-height: 48px; padding-inline: 0; + padding-block: 0; box-sizing: border-box; -webkit-text-decoration: none; text-decoration: none; @@ -229,6 +230,7 @@ exports[`BreadcrumbItem renders with default props 1`] = ` min-width: 80px; min-height: 48px; padding-inline: 0; + padding-block: 0; box-sizing: border-box; -webkit-text-decoration: none; text-decoration: none; @@ -404,6 +406,7 @@ exports[`BreadcrumbItem renders with overrides 1`] = ` min-width: 10px; min-height: 11px; padding-inline: 0; + padding-block: 0; box-sizing: border-box; -webkit-text-decoration: none; text-decoration: none; @@ -541,6 +544,7 @@ exports[`Breadcrumbs renders in large size 1`] = ` min-width: 120px; min-height: 64px; padding-inline: 0; + padding-block: 0; box-sizing: border-box; -webkit-text-decoration: none; text-decoration: none; @@ -837,6 +841,7 @@ exports[`Breadcrumbs renders in medium size 1`] = ` min-width: 80px; min-height: 48px; padding-inline: 0; + padding-block: 0; box-sizing: border-box; -webkit-text-decoration: none; text-decoration: none; @@ -1133,6 +1138,7 @@ exports[`Breadcrumbs renders in small size 1`] = ` min-width: 64px; min-height: 32px; padding-inline: 0; + padding-block: 0; box-sizing: border-box; -webkit-text-decoration: none; text-decoration: none; @@ -1429,6 +1435,7 @@ exports[`Breadcrumbs renders with default props 1`] = ` min-width: 80px; min-height: 48px; padding-inline: 0; + padding-block: 0; box-sizing: border-box; -webkit-text-decoration: none; text-decoration: none; @@ -1729,6 +1736,7 @@ exports[`Breadcrumbs renders with logical prop overrides 1`] = ` min-width: 80px; min-height: 48px; padding-inline: 0; + padding-block: 0; box-sizing: border-box; -webkit-text-decoration: none; text-decoration: none; @@ -2024,6 +2032,7 @@ exports[`Breadcrumbs renders with separator icon as overrides 1`] = ` min-width: 80px; min-height: 48px; padding-inline: 0; + padding-block: 0; box-sizing: border-box; -webkit-text-decoration: none; text-decoration: none; @@ -2319,6 +2328,7 @@ exports[`Breadcrumbs renders with separator overrides with TextBlock component 1 min-width: 80px; min-height: 48px; padding-inline: 0; + padding-block: 0; box-sizing: border-box; -webkit-text-decoration: none; text-decoration: none; @@ -2548,6 +2558,7 @@ exports[`Breadcrumbs renders with showTrailingSeparator 1`] = ` min-width: 80px; min-height: 48px; padding-inline: 0; + padding-block: 0; box-sizing: border-box; -webkit-text-decoration: none; text-decoration: none; diff --git a/src/breadcrumbs/defaults.ts b/src/breadcrumbs/defaults.ts index 5f36ce7490..f013ada1df 100644 --- a/src/breadcrumbs/defaults.ts +++ b/src/breadcrumbs/defaults.ts @@ -4,16 +4,19 @@ export default { typographyPreset: 'utilityButton010', stylePreset: 'breadcrumbItem', paddingInline: 'space000', + paddingBlock: 'space000', }, medium: { typographyPreset: 'utilityButton020', stylePreset: 'breadcrumbItem', paddingInline: 'space000', + paddingBlock: 'space000', }, large: { typographyPreset: 'utilityButton030', stylePreset: 'breadcrumbItem', paddingInline: 'space000', + paddingBlock: 'space000', }, }, breadcrumbs: { diff --git a/src/theme/__tests__/__snapshots__/theme.test.ts.snap b/src/theme/__tests__/__snapshots__/theme.test.ts.snap index 8250e7bcd3..ce95921da9 100644 --- a/src/theme/__tests__/__snapshots__/theme.test.ts.snap +++ b/src/theme/__tests__/__snapshots__/theme.test.ts.snap @@ -1521,16 +1521,19 @@ Object { }, "breadcrumbItem": Object { "large": Object { + "paddingBlock": "space000", "paddingInline": "space000", "stylePreset": "breadcrumbItem", "typographyPreset": "utilityButton030", }, "medium": Object { + "paddingBlock": "space000", "paddingInline": "space000", "stylePreset": "breadcrumbItem", "typographyPreset": "utilityButton020", }, "small": Object { + "paddingBlock": "space000", "paddingInline": "space000", "stylePreset": "breadcrumbItem", "typographyPreset": "utilityButton010", From 90641f9fb068b0e2d1406ce01fe67944c8a96a1b Mon Sep 17 00:00:00 2001 From: Xin00163 Date: Tue, 17 Jan 2023 14:21:28 +0000 Subject: [PATCH 2/2] fix(PPDSC-2696): update stories --- .../__tests__/breadcrumbs.stories.tsx | 28 +++++++++++++++---- 1 file changed, 22 insertions(+), 6 deletions(-) diff --git a/src/breadcrumbs/__tests__/breadcrumbs.stories.tsx b/src/breadcrumbs/__tests__/breadcrumbs.stories.tsx index 3923b6d85a..f7226206f1 100644 --- a/src/breadcrumbs/__tests__/breadcrumbs.stories.tsx +++ b/src/breadcrumbs/__tests__/breadcrumbs.stories.tsx @@ -221,9 +221,17 @@ export const StoryLogicalProps = () => ( overrides={{paddingBlock: 'space050'}} aria-label="padding-overrides" > - Breadcrumb item - Breadcrumb item - + + Breadcrumb item + + + Breadcrumb item + + Breadcrumb item @@ -233,9 +241,17 @@ export const StoryLogicalProps = () => ( overrides={{marginBlock: 'space050'}} aria-label="margin-overrides" > - Breadcrumb item - Breadcrumb item - + + Breadcrumb item + + + Breadcrumb item + + Breadcrumb item