Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend toNewsKitIcon parameter types #930

Closed
KayKostadinov opened this issue May 31, 2024 · 0 comments · Fixed by #931, #932 or #933
Closed

Extend toNewsKitIcon parameter types #930

KayKostadinov opened this issue May 31, 2024 · 0 comments · Fixed by #931, #932 or #933
Assignees
Labels
task A non user facing change triage This issue will be reviewed by the team

Comments

@KayKostadinov
Copy link
Contributor

Description

Extend toNewsKitIcon parameter types to include EmotionIcon.

This is needed due to an update in the @emotion-icons package. Bootstrapping a project with node 18 and react types 18 resolves the type EmotionIcon for the emotion icons. This results is a type error when passing them to the toNewsKitIcon transformer function.

Tasks/Steps

All known tasks/steps that need to be carried out

Acceptance Criteria

All acceptance criteria must be met before task can be marked as 'done'

Supporting Information

Process/sequence flows, wireframes, third party documentation, tech feasibility, architecture overview/documentation, high level design, data specs etc...

Dependencies

Any known business dependencies or reasons to engage with another team and input into their roadmap/timings

@KayKostadinov KayKostadinov added triage This issue will be reviewed by the team task A non user facing change labels May 31, 2024
@KayKostadinov KayKostadinov self-assigned this May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
task A non user facing change triage This issue will be reviewed by the team
Projects
None yet
1 participant