Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Grid Layout storybook examples using composable card #758

Open
n-dorman opened this issue Mar 23, 2023 · 4 comments
Open

Grid Layout storybook examples using composable card #758

n-dorman opened this issue Mar 23, 2023 · 4 comments
Assignees
@nathanparris
Labels
story a user facing change
Milestone
Storybook Enhance...

Comments

@n-dorman
Copy link
Contributor

We need to check the Grid layout Storybook examples and update to use the new composable card component:

https://www.figma.com/file/ieE2p1e8ZEZtfqPwOAvSwf/NewsKit---Storybook-Project---Layout?node-id=2117%3A28298&t=w9GESbIzqWB3xt6d-1
@n-dorman n-dorman added this to the Storybook Enhancements milestone Mar 23, 2023
@n-dorman n-dorman added this to NewsKit Mar 23, 2023
@JohnTParsons JohnTParsons added triage This issue will be reviewed by the team story a user facing change labels Apr 11, 2023
@jps jps removed the triage This issue will be reviewed by the team label Apr 11, 2023
@jps jps moved this to No longer needed in NewsKit Apr 11, 2023
@n-dorman n-dorman moved this from No longer needed to Analysis in NewsKit Apr 11, 2023
@n-dorman
Copy link
Contributor Author

@messmike Is there any additional information that needs to be added to this ticket after discussing with the team? Thanks

@messmike
Copy link
Contributor

@n-dorman I'll check this when I have time and will add a comment if needed. thanks

@messmike
Copy link
Contributor

messmike commented Apr 20, 2023 •
edited
Loading

If we can get the Content Bucket 1 slice example that uses GridLayout, the composable card, and the title bar built as an example for the times, that would be useful for us to share with the times engineers. WIP designs are here, and we will put together a handoff file to show overrides, new style presets etc: https://www.figma.com/file/41HrVTiyP8097dEpYRHGJG/v5.0-%F0%9F%9F%A2-Times-Components?node-id=598%3A177562&t=0bIEp5A9XlJzjNTE-1

@LukeFinch LukeFinch moved this from Analysis to Ready to do in NewsKit Apr 24, 2023
@nathanparris nathanparris self-assigned this Apr 24, 2023
@nathanparris nathanparris moved this from Ready to do to In progress in NewsKit Apr 24, 2023
@nathanparris nathanparris moved this from In progress to Design review in NewsKit Apr 26, 2023
@nathanparris
Copy link
Contributor

Updated story including The Times example https://www.figma.com/file/ieE2p1e8ZEZtfqPwOAvSwf/NewsKit---Storybook-Project---Layout?node-id=2117-28298&t=8n0QD6gk5d6dmum4-11

@nathanparris nathanparris moved this from Design review to Done in NewsKit Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nathanparris nathanparris

Labels
story a user facing change
Projects
NewsKit
Status: Done
Milestone
Storybook Enhancements
Development

No branches or pull requests
5 participants
@jps @JohnTParsons @n-dorman @messmike @nathanparris