Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Tooltip component scenarios - Storybook #729

Closed
jps opened this issue Mar 22, 2023 · 4 comments · Fixed by #823
Closed

Update Tooltip component scenarios - Storybook #729

jps opened this issue Mar 22, 2023 · 4 comments · Fixed by #823
Assignees
Labels
story a user facing change

Comments

@jps
Copy link
Contributor

jps commented Mar 22, 2023

Description

Updates to the Tooltip component scenarios- Storybook

Tasks/Steps

Using the designs update the storybook pages for the Tooltip component.

The designs include what should be on each page, and the title, description, and link to the documentation page on the site for the component.

Note the name of the pages also should be updated to match what we have in the designs.

Notes (main differences to what we have currently live versus the designs)

  • Default: removed variations - moved to own story
  • Placements and placements visual test - use what currently stands (screenshots below)
  • Variations: new story
  • Overrides: change colours and styles

Acceptance/Testing Criteria

Given I am in Storybook

When I view the Tooltip component pages

Then the pages will be updated as per the designs

And the pages will be within 1024x768 for Applitools snapshots.

Business Benefit/Value

Consistent Tooltip component examples for consumers, aligning to the NK branding.

@jps jps added this to NewsKit Mar 22, 2023
@jps jps converted this from a draft issue Mar 22, 2023
@jps jps added this to the Storybook Enhancements milestone Mar 22, 2023
@jps jps added the task A non user facing change label Mar 22, 2023
@GeriReid GeriReid added story a user facing change and removed task A non user facing change labels Mar 27, 2023
@LukeFinch LukeFinch moved this from Analysis to Ready for estimation in NewsKit Apr 3, 2023
@JohnTParsons JohnTParsons self-assigned this Apr 6, 2023
@JohnTParsons JohnTParsons moved this from Ready for estimation to In progress in NewsKit Apr 6, 2023
@JohnTParsons
Copy link
Collaborator

PR opened: #823

@JohnTParsons JohnTParsons moved this from In progress to Design review in NewsKit Apr 11, 2023
@nathanparris
Copy link
Contributor

@JohnTParsons. Thanks updating. I have some feedback listed below:

General

  • When I click on any element, it goes to the bottom of the page
  • Can you use a 4 column grid to match the design layout (Triggers, variations, no pointer, controlled)
  • Use default sizing for button and iconButton (except for placements and visual tests)

Placements + visual tests

  • Can the left and right buttons have a fixed width

Variations

  • Change content to "Show tooltip" for all (including links)

Controlled

  • Match to design layout

Styling overrides

  • Can the overrides be just applied to the button

@JohnTParsons
Copy link
Collaborator

@nathanparris Changes pushed

@nathanparris
Copy link
Contributor

@JohnTParsons Changes look good. Thanks.

@JohnTParsons JohnTParsons moved this from Design review to Peer review in NewsKit Apr 14, 2023
@JohnTParsons JohnTParsons moved this from Peer review to Done in NewsKit Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
story a user facing change
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants