Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Standfirst component scenarios - Storybook #723

Closed
jps opened this issue Mar 22, 2023 · 5 comments · Fixed by #881
Closed

Update Standfirst component scenarios - Storybook #723

jps opened this issue Mar 22, 2023 · 5 comments · Fixed by #881
Assignees
Labels
story a user facing change

Comments

@jps
Copy link
Contributor

jps commented Mar 22, 2023

Description

Updates to the Standfirst component scenarios- Storybook

Tasks/Steps

  • Using the designs update the storybook pages for the Standfirst component.
  • The designs include what should be on each page, and the title, description, and link to the documentation page on the site for the component.
  • Note the name of the pages also should be updated to match what we have in the designs.

Acceptance/Testing Criteria

Given I am in Storybook

When I view the Standfirst component pages

Then the pages will be updated as per the designs

And the pages will be within 1024x768 for Applitools snapshots.

Business Benefit/Value

Consistent Standfirst component examples for consumers, aligning to the NK branding.

@jps jps added this to NewsKit Mar 22, 2023
@jps jps converted this from a draft issue Mar 22, 2023
@jps jps added this to the Storybook Enhancements milestone Mar 22, 2023
@jps jps added task A non user facing change story a user facing change and removed task A non user facing change labels Mar 22, 2023
@jps jps removed the status in NewsKit Mar 28, 2023
@jps jps moved this to Backlog in NewsKit Apr 14, 2023
@jps jps moved this from Backlog to Analysis in NewsKit Apr 24, 2023
@LukeFinch LukeFinch moved this from Analysis to Ready to do in NewsKit May 4, 2023
@jannuk59 jannuk59 self-assigned this May 5, 2023
@jannuk59 jannuk59 moved this from Ready to do to In progress in NewsKit May 8, 2023
@jannuk59 jannuk59 moved this from In progress to Design review in NewsKit May 8, 2023
@GeriReid
Copy link
Contributor

GeriReid commented May 9, 2023

All looks good to me, thanks @jannuk59. Could you review @nathanparris?

@nathanparris
Copy link
Contributor

@jannuk59 Looks good for me too.

@jannuk59
Copy link
Contributor

jannuk59 commented May 9, 2023

Thanks @GeriReid and @nathanparris. Moving to peer review in a while.

@jannuk59 jannuk59 moved this from Design review to Peer review in NewsKit May 9, 2023
@jannuk59
Copy link
Contributor

@GeriReid and @nathanparris Please have a look at the PR comments #881 on using typographyPreset for the standfirst component and let me know your suggestions.

@jannuk59 jannuk59 moved this from Peer review to Done in NewsKit May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
story a user facing change
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants