Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dashboard): update line and table widget threshold to and from datatype #2713

Merged
merged 6 commits into from
Jul 17, 2024

Conversation

vagrawal-newrelic
Copy link
Contributor

@vagrawal-newrelic vagrawal-newrelic commented Jul 11, 2024

Description

This PR include fix for updating the datatype for "to" and "from" fields in threshold attribute for Table and Line widget in newrelic_one_dashboard.
This is done as a part to fix this #2703 GitHub issue
Jira Story
Uses changes from #1192 in newrelic-client-go.

Please include a summary of the change and which issue is fixed (if relevant).

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

Please delete options that are not relevant.

  • My commit message follows conventional commits
  • My code is formatted to Go standards
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes. Go here for instructions on running tests locally.

How to test this change?

Please describe how to test your changes. Include any relevant steps in the UI, HCL file(s), commands, etc

  • Create a Table and line widget in newrelic_one_dashboard widget in terraform file
  • specify the threshold values in these widget as float
  • Create the dashboard using "terraform plan"
  • check in UI if the dashboard is created with the widget or not and the threshold value should be same as specified in the TF file

…m' feilds data type from int to float

Updated the data type for the "to" and "From" feilds in "Threashold" in line and table widget from int to float(GitHub #2703)
@pranav-new-relic pranav-new-relic changed the title fix(Dashboard): Update line and table widget threashold 'to' and 'fro… fix(dashboard): update line and table widget threshold to and from datatype Jul 12, 2024
…test

Updated the go.mod file to use go-client commit specific version to pass the integration test
@pranav-new-relic
Copy link
Member

pranav-new-relic commented Jul 15, 2024

@vagrawal-newrelic all changes look good to me 😄 a final set of recommendations:

  • Your changes in newrelic-client-go (fix(dashboard): update line and table widget threshold to and from fields datatype from int to float64 newrelic-client-go#1192) have been merged and will soon be out with the latest version (I shall trigger a release in few minutes). Once done, please update the version of newrelic-client-go in this PR to the latest version you will see in some time.
  • Similar to updates made in the integration tests to use float values agains to and from in thresholds, please make a corresponding update in the examples in the documentation as well. You might want to refer to the original PR in which I added thresholds for line and table widgets which also includes documentation updates to show these values, which you can then, update to float values in your PR.
  • Once done, as a final check - using locally compiled changes in this branch, use the example in the description of this PR (and change threshold values to float), run a terraform apply, and then a terraform plan, to make sure there is no unintended drift. Test this multifold to make sure everything's fine.

Once done with all of the above, we should be good to go 👍

@pranav-new-relic
Copy link
Member

LGTM 👍

@pranav-new-relic pranav-new-relic merged commit 928e545 into main Jul 17, 2024
13 of 14 checks passed
@pranav-new-relic pranav-new-relic deleted the NR-288587-threshold-to-from-type-update branch July 17, 2024 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants