You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
Our aws-sdk instrumentation sets a symbol as a header which is then parsed by the http-outbound instrumentation to decide if DT should be disabled. This will not work in undici because at every hook point we have the headers have been parsed from an Object to a string. If the aws-sdk ever supports undici as the http client, this will become a problem. This is all hypothetical but called out in #921.
Feature Description
Provide an ability to disable DT from aws-sdk instrumentation that is properly parsed by undici instrumentation.
Additional context
We could probably just pass along an x header as and undici instrumentation look for it to decide if we want to disable DT for undici. Then we could even remove the header from the string before it actually made the http request
Priority
Please help us better understand this feature request by choosing a priority from the following options:
[Nice To Have]
The text was updated successfully, but these errors were encountered:
I don't think they will support undici in 2.x (since it will be deprecated at some point), but they do support custom http client in 3.x , but u do not have 3.x instrumentation yet, to support it u will have to change your instrumentation anyway newrelic/node-newrelic-aws-sdk#86
Is your feature request related to a problem? Please describe.
Our aws-sdk instrumentation sets a symbol as a header which is then parsed by the http-outbound instrumentation to decide if DT should be disabled. This will not work in undici because at every hook point we have the headers have been parsed from an Object to a string. If the aws-sdk ever supports undici as the http client, this will become a problem. This is all hypothetical but called out in #921.
Feature Description
Provide an ability to disable DT from aws-sdk instrumentation that is properly parsed by undici instrumentation.
Additional context
We could probably just pass along an x header as and undici instrumentation look for it to decide if we want to disable DT for undici. Then we could even remove the header from the string before it actually made the http request
Priority
Please help us better understand this feature request by choosing a priority from the following options:
[Nice To Have]
The text was updated successfully, but these errors were encountered: