Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow undici to understand a header to disable DT #935

Closed
bizob2828 opened this issue Sep 28, 2021 · 2 comments
Closed

Allow undici to understand a header to disable DT #935

bizob2828 opened this issue Sep 28, 2021 · 2 comments

Comments

@bizob2828
Copy link
Member

Is your feature request related to a problem? Please describe.

Our aws-sdk instrumentation sets a symbol as a header which is then parsed by the http-outbound instrumentation to decide if DT should be disabled. This will not work in undici because at every hook point we have the headers have been parsed from an Object to a string. If the aws-sdk ever supports undici as the http client, this will become a problem. This is all hypothetical but called out in #921.

Feature Description

Provide an ability to disable DT from aws-sdk instrumentation that is properly parsed by undici instrumentation.

Additional context

We could probably just pass along an x header as and undici instrumentation look for it to decide if we want to disable DT for undici. Then we could even remove the header from the string before it actually made the http request

Priority

Please help us better understand this feature request by choosing a priority from the following options:
[Nice To Have]

@artur-ma
Copy link

artur-ma commented Sep 30, 2021

I don't think they will support undici in 2.x (since it will be deprecated at some point), but they do support custom http client in 3.x , but u do not have 3.x instrumentation yet, to support it u will have to change your instrumentation anyway newrelic/node-newrelic-aws-sdk#86

issue on aws-sdk-v3 side: aws/aws-sdk-js-v3#2569

@bizob2828
Copy link
Member Author

We're closing as this is not an issue. If it ever becomes an issue we can log a ticket to capture the steps to reproduce

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants