Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle attribute reconciliation when a message consumer span ends #2932

Closed
bizob2828 opened this issue Feb 10, 2025 · 1 comment · Fixed by #2957
Closed

Handle attribute reconciliation when a message consumer span ends #2932

bizob2828 opened this issue Feb 10, 2025 · 1 comment · Fixed by #2957
Assignees

Comments

@bizob2828
Copy link
Member

bizob2828 commented Feb 10, 2025

Description

In our otel bridge span processor we have logic to reconcile span attributes with the appropriate names of the segment attributes. Even though when we create spans from segments, we need to ensure the expected segment attributes exist. This requires a little digging. There is mapping logic in lib/spans/span-event.js for generic spans(which this gets assigned). But you will also need to look at the instrumentation for message shim consumption. Since these spans create transactions we also have to end the transaction when the span ends.

Note: We assign generic as the span kind. We should enhance to assign the appropriate kind

@workato-integration
Copy link

@newrelic-node-agent-team newrelic-node-agent-team moved this to Triage Needed: Unprioritized Features in Node.js Engineering Board Feb 10, 2025
@kmudduluru kmudduluru moved this from Triage Needed: Unprioritized Features to In Quarter in Node.js Engineering Board Feb 10, 2025
@kmudduluru kmudduluru moved this from In Quarter to To do: In current sprint in Node.js Engineering Board Feb 18, 2025
@jsumners-nr jsumners-nr self-assigned this Feb 19, 2025
@jsumners-nr jsumners-nr moved this from To do: In current sprint to In progress: Issues being worked on in Node.js Engineering Board Feb 19, 2025
@github-project-automation github-project-automation bot moved this from In progress: Issues being worked on to Done: Issues recently completed in Node.js Engineering Board Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done: Issues recently completed
Development

Successfully merging a pull request may close this issue.

2 participants