feat(entities): add support for tags in EntityOutline types #1146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pranav-new-relic
changed the title
pranav-new-relic
force-pushed
the
NR-273644
branch
from
9697671 to
9f42075
Compare
abasha1234
force-pushed
the
NR-273644
branch
3 times, most recently
from
3d43ac0 to
f332aa1
Compare
pranav-new-relic
force-pushed
the
NR-273644
branch
from
f332aa1 to
612d979
Compare
chore(deps): update some more deps (#1164) feat: Add tags for missing entities feat: Retrive tags from entity api
pranav-new-relic
force-pushed
the
NR-273644
branch
from
4deefde to
3c7e35e
Compare
pranav-new-relic
force-pushed
the
NR-273644
branch
from
134d3d2 to
60ba48a
Compare
pranav-new-relic
force-pushed
the
NR-273644
branch
from
97829a9 to
0193b14
Compare
pranav-new-relic
changed the title
chore(deps): update some more deps (#1164) feat: Add tags for missing entities feat: Retrive tags from entity api chore(deps): update git-chglog, fastjson, mergo (#1148) chore(deps): update dependencies chore(deps): Update module github.com/goreleaser/goreleaser to v1.26.2 (#1152) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> chore(deps): update some more dependencies (#1161) chore(deps): update some more deps (#1164) chore: Add test validation for entity tags chore(deps): Update module github.com/caarlos0/svu to v2 (#1167) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: pranav-new-relic <[email protected]> feat(entities): add support for tags in EntityOutline types chore(deps): adding missing dependency chore(entities): refactor code in types feat(entities): add support for tags in EntityOutline types Empty commit chore(deps): eliminate an unnecessary dependency
| @@ -17345,6 +17345,7 @@ type EntityOutlineInterface interface { | |||
| GetGUID() common.EntityGUID | |||
| GetName() string | |||
| GetType() string | |||
| GetTags() []EntityTag | |||
There was a problem hiding this comment.
for anyone finding this PR in future: no other changes are needed in this file, since Tutone seems to have already populated all fields implementing the EntityOutlineInterface with a Tags attribute and a GetTags method.
This has been verified and checked multiple times by @abasha1234 and me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Support for Tags to the newrelic_entity Data Source
Ticket: https://new-relic.atlassian.net/browse/NR-273644