fix(alerts): Removed omitempty from RunbookURL in NrqlConditionUpdateBase #1030
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to address the issues raised in newrelic/terraform-provider-newrelic#2332 where the runbook_url attribute cannot be unset/deleted on update. To fix this I have removed the omitempty option from the RunbookURL field on the update struct.
I wasn't able to add an integration test for this change due to a timing issue that still exists for updates based the comments here in the existing integration tests. (I did try to write tests for the updated fields but that resulted in said timing errors.)
Thanks!