Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(alerts): Removed omitempty from RunbookURL in NrqlConditionUpdateBase #1030

Conversation

usfdmiller
Copy link
Contributor

This PR attempts to address the issues raised in newrelic/terraform-provider-newrelic#2332 where the runbook_url attribute cannot be unset/deleted on update. To fix this I have removed the omitempty option from the RunbookURL field on the update struct.

I wasn't able to add an integration test for this change due to a timing issue that still exists for updates based the comments here in the existing integration tests. (I did try to write tests for the updated fields but that resulted in said timing errors.)

Thanks!

@CLAassistant
Copy link

CLAassistant commented Apr 28, 2023

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@Nandu-pns Nandu-pns changed the title fix(alerts):Removed omitempty from RunbookURL in NrqlConditionUpdateBase fix(alerts): Removed omitempty from RunbookURL in NrqlConditionUpdateBase May 3, 2023
@Nandu-pns
Copy link
Contributor

Hi @usfdmiller, Could you please update or rebase the branch with the base branch when you get chance as it's currently out-of-date ? Thanks !

@usfdmiller
Copy link
Contributor Author

Hi @usfdmiller, Could you please update or rebase the branch with the base branch when you get chance as it's currently out-of-date ? Thanks !

I think I updated the branch correctly. I'm still pretty new to the Github PR process so I click buttons and hope for the best.

@Nandu-pns Nandu-pns merged commit f100ace into newrelic:main May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants