-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(notifications): add name to filter #1014
Merged
pranav-new-relic
merged 5 commits into
newrelic:main
from
lzaga-newrelic:add-name-to-filter
Jun 14, 2023
Merged
fix(notifications): add name to filter #1014
pranav-new-relic
merged 5 commits into
newrelic:main
from
lzaga-newrelic:add-name-to-filter
Jun 14, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1014 +/- ##
=======================================
Coverage 41.62% 41.62%
=======================================
Files 79 79
Lines 4956 4956
=======================================
Hits 2063 2063
Misses 2745 2745
Partials 148 148
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
8 tasks
Looks good to me 👍 |
pranav-new-relic
previously approved these changes
Jun 12, 2023
lzaga-newrelic
force-pushed
the
add-name-to-filter
branch
from
June 12, 2023 11:12
3dad44b
to
8d8eb23
Compare
pranav-new-relic
previously approved these changes
Jun 12, 2023
pranav-new-relic
approved these changes
Jun 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add to AiNotificationsDestinationFilter the Name attribute.