Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[newrelic-logging] Add ability to tag the resources you want the logs captures (or opt-out) #78

Open
jsubirat opened this issue Jun 30, 2020 · 3 comments

Comments

@jsubirat
Copy link
Contributor

Is your feature request related to a problem? Please describe.

[Originally posted by @shicholas here]

Installation and setup with this was easy and straightforward, nice work!

It'd be nice to opt-in or out of New Relic collecting logs based on metadata tags we assign to our K8 resources, or specify a K8 namespace to collect logs from. We have some third-party managed resources we do not care to collect logs from (e.g. Azure's Key Vault).

Describe the solution you'd like

A clear and concise description of what you want to happen.

Describe alternatives you've considered

A clear and concise description of any alternative solutions or features you've considered.

Additional context

Add any other context or screenshots about the feature request here.

@jsubirat
Copy link
Contributor Author

Hi @shicholas, could you please fill the details in the description above? Many thanks in advance!

@shicholas
Copy link

Hi @jsubirat I can't edit your comment so I'll add it below:

Is your feature request related to a problem? Please describe.

[Originally posted by @shicholas here]

While it's not a problem, we do get a lot of noise from logs that we don't care about, like helm-installed libraries, and would prefer to only ingest the logs of our application as tagged in metadata.

Describe the solution you'd like

We'd like the ability to add a metadata tag to the pods/deployments that we want our logs sent to New Relic.

Describe alternatives you've considered

The alternative perhaps could be to use the Fluentd New Relic log integration, however, if possible, we prefer the easy flexibility of installing a simple helm chart with metadata described above.

Additional context

Add any other context or screenshots about the feature request here.

@devurandom
Copy link

devurandom commented Jan 8, 2021

Taking a look at https://github.com/newrelic/helm-charts/blob/master/charts/newrelic-logging/k8s/README.md#configuration-notes, it seems as if newrelic-logging is not actually capturing the logs using a Kubernetes API, but instead captures them on each Kubernetes node from the Kubelet's / Docker's internal log files.

Does newrelic-logging even have access to any metadata of the Kubernetes API objects, so that it could opt-in/opt-out based on a Kubernetes label or annotation?

(#251 is a request to be able to specify the logtype using Kubernetes object metadata, which might be somewhat related.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants