You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Looking at this again the getCurrentPageFirstResultOffset and getCurrentPageLastResultOffset are used for the doctrine query and templates. Might need to split these out.
calculateFirstResultOffset()
getCurrentPageFirstResultOffset()
calculateLastResultOffset()
getCurrentPageLastResultOffset()
all need reworking. They are calculating wrong.
calculateFirstResultOffset
returns 1.getCurrentPageLastResultOffset
doesn't take into consideration half responses on the last page.This might be a good thing to write tests for.
The text was updated successfully, but these errors were encountered: