Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds Vulp Markings to Felinids (DeltaV #1694) #2796

Merged
merged 3 commits into from
Jan 31, 2025
Merged

Adds Vulp Markings to Felinids (DeltaV #1694) #2796

merged 3 commits into from
Jan 31, 2025

Conversation

ewokswagger
Copy link
Contributor

@ewokswagger ewokswagger commented Jan 27, 2025 •
edited by whatston3
Loading

About the PR

Added Vulpkanin ears and tails to Felinid's customization options. port of DeltaV-Station/Delta-v#1694

Why / Balance

More customization good. Also, it allows more characters from DV to be ported properly.

How to test

Create a Felidid character.
Go to markings.
Add Vulp tails or ears.

Media

image

Requirements

Breaking changes

Changelog

🆑 ghost

  • tweak: Added Vulpkanin tail and ear options for Felinid customization.

@dvir001
Copy link
Contributor

dvir001 commented Jan 27, 2025

You cannot call this a port if you dont mention even ones the original PR

@Bonaout
Copy link
Contributor

Bonaout commented Jan 27, 2025

Omg it looks so cute

@ewokswagger
Copy link
Contributor Author

Updated!

@ewokswagger ewokswagger changed the title Port DV Vulpkanin's getting Felinid's ears+tails Port DeltaV #1694 Vulpkanin's getting Felinid's ears+tails Jan 28, 2025
@ewokswagger ewokswagger changed the title Port DeltaV #1694 Vulpkanin's getting Felinid's ears+tails Port DeltaV Adds Vulp Markings to Felinids #1694 Jan 28, 2025
@ewokswagger ewokswagger changed the title Port DeltaV Adds Vulp Markings to Felinids #1694 Port Adds Vulp Markings to Felinids (DeltaV #1694) Jan 28, 2025
@ewokswagger ewokswagger changed the title Port Adds Vulp Markings to Felinids (DeltaV #1694) Adds Vulp Markings to Felinids (DeltaV #1694) Jan 28, 2025
@dvir001 dvir001 added S: Needs Review This PR is awaiting reviews and removed S: DO NOT MERGE labels Jan 28, 2025
@dvir001 dvir001 self-requested a review January 28, 2025 08:21
whatston3
whatston3 approved these changes Jan 31, 2025
View reviewed changes
Copy link
Contributor

@whatston3 whatston3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Port matches DeltaV (cherry-pick next time to give credit via commit).

Works fine, seems a little weird to me but alright.

Added the original author to the changelog.

@whatston3 whatston3 added S: Approved and removed S: Needs Review This PR is awaiting reviews labels Jan 31, 2025
@dvir001 dvir001 merged commit c465818 into new-frontiers-14:master Jan 31, 2025
12 checks passed
FrontierATC added a commit that referenced this pull request Jan 31, 2025
@FrontierATC
Automatic Changelog (#2796)
464dc21
percent-temp-percent pushed a commit to Corvax-Frontier/Frontier that referenced this pull request Feb 24, 2025
@ewokswagger @dvir001 @percent-temp-percent
Port DV Vulpkanin's getting Felinid's ears+tails (new-frontiers-14#2796)
dfb4e23 
Co-authored-by: Dvir <[email protected]>
percent-temp-percent pushed a commit to Corvax-Frontier/Frontier that referenced this pull request Feb 24, 2025
@FrontierATC @percent-temp-percent
Automatic Changelog (new-frontiers-14#2796)
a56d6d9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whatston3 whatston3 whatston3 approved these changes

@dvir001 dvir001 Awaiting requested review from dvir001

Assignees
No one assigned
Labels
No C# S: Approved YML
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ewokswagger @dvir001 @Bonaout @whatston3