Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

-c/--colors are supposed to default to always. It doesn't default it requires the parameter. #67

Closed
nevdelap opened this issue Feb 2, 2019 · 2 comments
Closed

-c/--colors are supposed to default to always. It doesn't default it requires the parameter. #67

nevdelap opened this issue Feb 2, 2019 · 2 comments
Assignees
@nevdelap
Labels
bug
Milestone
1.2.7

Comments

@nevdelap
Copy link
Owner

nevdelap commented Feb 2, 2019 •
edited
Loading

Is a bug introduced by issue #46 because all the tests use the long option. See if it is possible to default an option that expects to have a value, probably not, maybe separate the -c and --colors to be separate options - -c cannot take an argument. Then add a test for the short option.
@nevdelap
Copy link
Owner Author

nevdelap commented Feb 2, 2019

-c defaults if it is the last argument, but it things the next argument is its value if it isn't the last argument.

@nevdelap nevdelap added this to the 1.2.7 milestone Feb 2, 2019
@nevdelap nevdelap self-assigned this Feb 2, 2019
@nevdelap nevdelap added the bug label Feb 2, 2019
@nevdelap
Copy link
Owner Author

nevdelap commented Feb 2, 2019

Fixed.

@nevdelap nevdelap closed this as completed Feb 2, 2019
@nevdelap nevdelap changed the title -c is supposed to default to auto. It doesn't default it requires the parameter. -c is supposed to default to always. It doesn't default it requires the parameter. Feb 4, 2019
@nevdelap nevdelap changed the title -c is supposed to default to always. It doesn't default it requires the parameter. -c/--colors are supposed to default to always. It doesn't default it requires the parameter. Feb 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nevdelap nevdelap

Labels
bug
Projects
None yet
Milestone
1.2.7
Development

No branches or pull requests
1 participant
@nevdelap