Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

edit enhancements involving add/remove/update conditions #112

Closed
nicoalee opened this issue Sep 28, 2021 · 4 comments · Fixed by #244
Closed

edit enhancements involving add/remove/update conditions #112

nicoalee opened this issue Sep 28, 2021 · 4 comments · Fixed by #244
Labels

Comments

@nicoalee
Copy link
Collaborator

No description provided.

@nicoalee
Copy link
Collaborator Author

note: this includes updating the associated weights as well

@nicoalee
Copy link
Collaborator Author

do we ever want users to be able to delete conditions? @adelavega @jdkent

@jdkent
Copy link
Member

jdkent commented Mar 16, 2022

I would say users can delete conditions when:

  1. they own the condition
  2. the condition is not being used in any other analysis

it would feel weird if person B used a condition from person A and if person A deleted the condition, Person B would no longer have that condition in their analysis.

I expect person B to still have that condition in their analysis.

@nicoalee
Copy link
Collaborator Author

we might have to create some sort of global "Manage Conditions Page" then because it doesn't really make sense to handle condition management if you're editing a contrast

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants