Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Virtualize rendering of result in ResultContainer #40

Open
rmanaem opened this issue Mar 1, 2024 · 3 comments
Open

Virtualize rendering of result in ResultContainer #40

rmanaem opened this issue Mar 1, 2024 · 3 comments
Labels
_flag:stale [BOT ONLY] Flag issue that hasn't been updated in a while and needs to be triaged again performance Performance improvement or fix to performance degradation. someday Not a priority right now, but we want to keep this around to think or discuss more.

Comments

@rmanaem
Copy link
Contributor

rmanaem commented Mar 1, 2024

At the moment using the select-all checkbox leads to re-rendering all ResultCard components which takes 1-2 seconds and affects the user experience.

As part of addressing #17 we've tried using

Our options from here are:

@rmanaem rmanaem added performance Performance improvement or fix to performance degradation. type:bug labels Mar 1, 2024
Copy link

We want to keep our issues up to date and active. This issue hasn't seen any activity in the last 75 days.
We have applied the _flag:stale label to indicate that this issue should be reviewed again.
When you review, please reread the spec and then apply one of these three options:

  • prioritize: apply the flag:schedule label to suggest moving this issue into the backlog now
  • close: if the issue is no longer relevant, explain why (give others a chance to reply) and then close.
  • archive: sometimes an issue has important information or ideas but we won't work on it soon. In this case
    apply the someday label to show that this won't be prioritized. The stalebot will ignore issues with this
    label in the future. Use sparingly!

@github-actions github-actions bot added the _flag:stale [BOT ONLY] Flag issue that hasn't been updated in a while and needs to be triaged again label May 15, 2024
@surchs surchs removed the type:bug label Dec 17, 2024
@github-actions github-actions bot removed the _flag:stale [BOT ONLY] Flag issue that hasn't been updated in a while and needs to be triaged again label Dec 17, 2024
Copy link

github-actions bot commented Mar 3, 2025

We want to keep our issues up to date and active. This issue hasn't seen any activity in the last 75 days.
We have applied the _flag:stale label to indicate that this issue should be reviewed again.
When you review, please reread the spec and then apply one of these three options:

  • prioritize: apply the flag:schedule label to suggest moving this issue into the backlog now
  • close: if the issue is no longer relevant, explain why (give others a chance to reply) and then close.
  • archive: sometimes an issue has important information or ideas but we won't work on it soon. In this case
    apply the someday label to show that this won't be prioritized. The stalebot will ignore issues with this
    label in the future. Use sparingly!

@github-actions github-actions bot added the _flag:stale [BOT ONLY] Flag issue that hasn't been updated in a while and needs to be triaged again label Mar 3, 2025
@surchs
Copy link
Contributor

surchs commented Mar 6, 2025

The performance issue was addressed by #39 with memoization, however the virtualization issue could still be addressed if it becomes a performance bottleneck again

@surchs surchs added the someday Not a priority right now, but we want to keep this around to think or discuss more. label Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
_flag:stale [BOT ONLY] Flag issue that hasn't been updated in a while and needs to be triaged again performance Performance improvement or fix to performance degradation. someday Not a priority right now, but we want to keep this around to think or discuss more.
Projects
None yet
Development

No branches or pull requests

2 participants