Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added schema definition for yaml files in .neuro #699

Merged
merged 9 commits into from
Nov 28, 2024
Merged

Conversation

jordyantunes
Copy link
Contributor

@jordyantunes jordyantunes commented Nov 27, 2024

This version includes changes to the workflow and project configuration files to enable code completion and validation by adding schema references to Apolo's config yaml files. These changes will improve the development experience by providing better code completion and validation.

Changes:

Copy link

linear bot commented Nov 27, 2024

@YevheniiSemendiak
Copy link
Contributor

Please, add changelog.

Here's an example:
https://github.com/neuro-inc/flow-template/tree/747908964c680f6679c45e1d9723d35c9e9d31af/CHANGELOG.D

For reference, we are using towncrier to generate changelogs.
tl; dr: put a file into the CHANGELOG.D folder, the filename is <pr-number>.(feature|bugfix|misc), the content is a description of changes applied in a PR.

@YevheniiSemendiak
Copy link
Contributor

Let's also do the same here: https://github.com/neuro-inc/flow-template-barebone

@costefan costefan self-requested a review November 28, 2024 20:02
Copy link
Contributor

@costefan costefan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@jordyantunes jordyantunes merged commit 7f261bd into master Nov 28, 2024
12 checks passed
@jordyantunes jordyantunes deleted the MLO-35 branch November 28, 2024 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants