Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit tests failures on default Windows console #188

Closed
wiiitek opened this issue Feb 9, 2020 · 1 comment
Closed

Unit tests failures on default Windows console #188

wiiitek opened this issue Feb 9, 2020 · 1 comment
Assignees
Milestone

Comments

@wiiitek
Copy link
Contributor

wiiitek commented Feb 9, 2020

Unit tests use FileLoader which uses default platform encoding.

It could be better if we specify the encoding for loaded files.

See also pull request: #189

While building the project on Windows 8.1 in my defult console I get:

[INFO] Results:
[INFO]
[ERROR] Failures:
[ERROR]   IssuesTest.shouldCompileJadeToHtmlWithReaderTemplateLoader:72->compareJade:100 65.jade expected:<... ?>
<p>Ch. & de la M[?lé]e 12</p>> but was:<... ?>
<p>Ch. & de la M[ĂŞlĂ?]e 12</p>>
[ERROR]   IssuesTest.shouldCompileJadeToHtmlWithReaderTemplateLoader:72->compareJade:100 98.jade expected:<..."utf-8" ?>
<summary>[éáú]</summary>> but was:<..."utf-8" ?>
<summary>[�áú]</summary>>
[ERROR]   IssuesTest.shouldCompileJadeToHtmlWithReaderTemplateLoader:72->compareJade:100 98b.jade expected:<...onal.dtd">
<summary>[éáú]</summary>> but was:<...onal.dtd">
<summary>[�áú]</summary>>
[INFO]
[ERROR] Tests run: 481, Failures: 3, Errors: 0, Skipped: 8
@chbloemer
Copy link
Contributor

Merged for 1.3.1 release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants