-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fix the umd builds #2214
fix: Fix the umd builds #2214
Conversation
Removes the module issue for windows same case due to alias resolution.
This has caused some issues in resolving the path. Best practices. Needs a lint. 😀
Preview proposed changes to the CMS demo site in the link below: Built with commit d659713 |
@erquhart I found these issues. Not all breaking, because the case issues are windows issues mostly. I am working on an es6 bundle PR and these things showed up right away, so it was a good thing. 😜 |
@erquhart I keep forgetting to ask you if you want me to return those export names back for the backends or follow the same export names as the widgets, so we are ready for them to also have a register name as 'controlComponent'. Although they are not really components as much as control class modules. |
Oh yeah, I meant to content on that in the original pull requests, the nomenclature should be changed to be specific to backends as "control" doesn't really apply there. Awesome to hear you're working on ES6 modules!!! Sent with GitHawk |
Ok, no problem. I wonder if they should follow a common for export like the widgets, so we can make the API the same way?
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks @talves!
Preview proposed changes to netlifycms.org in the link below: Built with commit d659713 |
Summary
Test plan
Same tests as original PR #2141
A picture of a cute animal (not mandatory but encouraged)
🐢