Results of the spike investigation into CMake. #7114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amoss
requested review from
cosmix,
vlvkobal,
ilyam8,
mfundul,
thiagoftsm and
stelfrag
Manage this branch in SquashTest this branch here: https://amossspike-cmake-clean-5aq6q.squash.io |
vlvkobal
approved these changes
Oct 17, 2019
mfundul
approved these changes
Oct 17, 2019
thiagoftsm
reviewed
Oct 17, 2019
| Note: I did not find an explicit way to select compiler when both `clang` and `gcc` are | ||
| present. We might have an implicit way (like redirecting `cc`) but we should put one in. | ||
|
|
||
|
|
There was a problem hiding this comment.
Why do you have 3 blank lines here?
There was a problem hiding this comment.
For luck :) I can remove them...
There was a problem hiding this comment.
Nice, I did not wanna force nobody approve it again! :D
thiagoftsm
approved these changes
Oct 17, 2019
There was a problem hiding this comment.
We have a format problem, but this is small, congratulations @amoss !
jackyhuang85
pushed a commit
to jackyhuang85/netdata
that referenced
this pull request
Jan 1, 2020
The BUILD.md will be updated during the progress of netdata#7150.
Saruspete
pushed a commit
to Saruspete/netdata
that referenced
this pull request
May 21, 2020
The BUILD.md will be updated during the progress of netdata#7150.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4310
Component Name
area/deamon
Additional Information
This is a summary of the investigation results from the spike. Everything is contained in
BUILD.mdin the root of the repo. The tl;dr is "yes, we should switch to cmake", and we know how to implement each of the cases that we will encounter. This is not a strict recipe for how to do this as we had to control the scope of the investigation and start writing a prototype of the new build-system.Everybody who is affected by changing build-systems should review the file. [If I've missed anybody as reviewer that is affected please add them]. If you any major problems please comment straight away so that we can start discussing them. If you don't see anything major then the next step will be an internal meeting to check that we have a common understanding of how the replacement will work, and what effect it will have on everybody's areas. After that meeting I will create a fresh issue (connect/close any old outstanding issues) and describe what needs to be done in the prototype in enough detail that we can estimate timescales (based on the steps in the Recommendations section).
The document is not attached to the pull-request separately as it will need changes based on feedback and I don't want a stale copy of it.