Coverity 20190924 #6941
Merged
Coverity 20190924 #6941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the switch the library stops case this pointer is NULL, so there is not necessity to processed with tests
The current code tries to copy the same size of the variable, another possible solution would be to use a function to sanitize the code, I will try this first
Considering that we are testing the variable value one line above The division will always happen
For this specific case we do not have the possibility to have memory leak, valgrind confirms this, but I am adding a new variable here to the stack to discard the warning
thiagoftsm
requested review from
cakrit,
cosmix,
mfundul and
vlvkobal
as code owners
Manage this branch in SquashTest this branch here: https://thiagoftsmcoverity-20190924-odya0.squash.io |
netdatabot
added
area/collectors
mfundul
approved these changes
Oct 2, 2019
Saruspete
pushed a commit
to Saruspete/netdata
that referenced
this pull request
Oct 9, 2019
* coverity_20190924: Fix 215633 In the switch the library stops case this pointer is NULL, so there is not necessity to processed with tests * coverity_20190924: Fix 338067 The current code tries to copy the same size of the variable, another possible solution would be to use a function to sanitize the code, I will try this first * coverity_20190924: Fix 348638 Considering that we are testing the variable value one line above The division will always happen * coverity_20190924: Fix 348640 For this specific case we do not have the possibility to have memory leak, valgrind confirms this, but I am adding a new variable here to the stack to discard the warning
jackyhuang85
pushed a commit
to jackyhuang85/netdata
that referenced
this pull request
Jan 1, 2020
* coverity_20190924: Fix 215633 In the switch the library stops case this pointer is NULL, so there is not necessity to processed with tests * coverity_20190924: Fix 338067 The current code tries to copy the same size of the variable, another possible solution would be to use a function to sanitize the code, I will try this first * coverity_20190924: Fix 348638 Considering that we are testing the variable value one line above The division will always happen * coverity_20190924: Fix 348640 For this specific case we do not have the possibility to have memory leak, valgrind confirms this, but I am adding a new variable here to the stack to discard the warning
Saruspete
pushed a commit
to Saruspete/netdata
that referenced
this pull request
May 21, 2020
* coverity_20190924: Fix 215633 In the switch the library stops case this pointer is NULL, so there is not necessity to processed with tests * coverity_20190924: Fix 338067 The current code tries to copy the same size of the variable, another possible solution would be to use a function to sanitize the code, I will try this first * coverity_20190924: Fix 348638 Considering that we are testing the variable value one line above The division will always happen * coverity_20190924: Fix 348640 For this specific case we do not have the possibility to have memory leak, valgrind confirms this, but I am adding a new variable here to the stack to discard the warning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes part of #6924
This PR fixes 4 issues that are present in our code according Coverity. I did not touch some collectors, because I will need to study more the code to understand what we have there and the database engine that Markos is already taking care.
Component Name
Health
Daemon
Additional Information