Fix crash in malloc #6583
Merged
Fix crash in malloc #6583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The system was setting NULL in an address without to have the values
After to fix the SSL, the script were not 100% compatible, so I am bringing the solution here
thiagoftsm
requested review from
cakrit,
ktsaou,
mfundul and
vlvkobal
as code owners
mfundul
suggested changes
Aug 1, 2019
mfundul
reviewed
Aug 1, 2019
Fixes reported in the issue related a possible NULL value to be kept and wrong variable
mfundul
suggested changes
Aug 1, 2019
It was a missing if yet, so I changed it, no less important I inverted the check order inside if to be more readable
mfundul
approved these changes
Aug 1, 2019
paulkatsoulakis
approved these changes
Aug 1, 2019
jacekkolasa
pushed a commit
to jacekkolasa/netdata
that referenced
this pull request
Aug 6, 2019
* Server Crashing: URL search path The system was setting NULL in an address without to have the values * Server Crashing: URL script After to fix the SSL, the script were not 100% compatible, so I am bringing the solution here * Server Crashing: Fixes reported in the issue related a possible NULL value to be kept and wrong variable * Server Crashing: Readable code and missing if It was a missing if yet, so I changed it, no less important I inverted the check order inside if to be more readable
jacekkolasa
pushed a commit
to jacekkolasa/netdata
that referenced
this pull request
Aug 6, 2019
* Server Crashing: URL search path The system was setting NULL in an address without to have the values * Server Crashing: URL script After to fix the SSL, the script were not 100% compatible, so I am bringing the solution here * Server Crashing: Fixes reported in the issue related a possible NULL value to be kept and wrong variable * Server Crashing: Readable code and missing if It was a missing if yet, so I changed it, no less important I inverted the check order inside if to be more readable
jackyhuang85
pushed a commit
to jackyhuang85/netdata
that referenced
this pull request
Jan 1, 2020
* Server Crashing: URL search path The system was setting NULL in an address without to have the values * Server Crashing: URL script After to fix the SSL, the script were not 100% compatible, so I am bringing the solution here * Server Crashing: Fixes reported in the issue related a possible NULL value to be kept and wrong variable * Server Crashing: Readable code and missing if It was a missing if yet, so I changed it, no less important I inverted the check order inside if to be more readable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The netdata has a random error to allocate memory in some requests according with outputs we were receiving from our demo server.
After to check the valgrind output, it was possible to verify that the malloc error could happen steps before due a set of values in an address NULL. This pull request fixes this checking the existence of a valid address before to set the value.
Component Name
web/ url parser
Additional Information
It fixes #6582