Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: prevent multi times dialing kad connection to the same peer #20

Merged
merged 3 commits into from
Nov 26, 2018
Merged

fix: prevent multi times dialing kad connection to the same peer #20

merged 3 commits into from
Nov 26, 2018

Conversation

jjyr
Copy link
Contributor

@jjyr jjyr commented Nov 22, 2018

Fixed the kad discovery problems

@jjyr jjyr added the bug label Nov 22, 2018
@doitian
Copy link
Member

doitian commented Nov 23, 2018

@TheWaWaR @quake any feedback?

doitian
doitian previously requested changes Nov 23, 2018
View reviewed changes
Copy link
Member

@doitian doitian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commits c88464b and 1b41dc9 are too trivial to be included in the history. Either use Squash and merge, or rebase the PR locally.

@doitian doitian dismissed their stale review November 23, 2018 08:57

Will squash and merge when aprooved

@quake quake merged commit 01bcaf4 into develop Nov 26, 2018
@doitian doitian deleted the jjyr/fix-kad-dialing branch November 26, 2018 08:22
contrun pushed a commit to contrun/ckb that referenced this pull request Jan 23, 2024
@eval-exec
Merge pull request nervosnetwork#20 from contrun/sync-after-restart: …
9f05dc5 
…Add integration test to check correctly sync after restart

Add integration test to check correctly sync after restart
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quake quake quake approved these changes

@doitian doitian doitian left review comments

@TheWaWaR TheWaWaR Awaiting requested review from TheWaWaR

@zhangsoledad zhangsoledad Awaiting requested review from zhangsoledad

Assignees

@quake quake

@TheWaWaR TheWaWaR

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jjyr @doitian @quake @TheWaWaR