Changes to how DeviceLinks are supervised #1187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
oestrich
commented
Jan 16, 2024
oestrich
commented
- Partition supervisor for the DynamicSupervisor, with thousands of devices connected the single DynamicSupervisor could get overloaded, partition it to help reduce processing changing state quickly
- Start a DeviceLink with the ID only, to help reduce state inside the supervisor, only store the device's ID in the supervisor state (since it's part of the child_spec that's stored in the supervisor state)
- Remove the supervisor module to simplify, put the one function that matters in the DeviceLink module directly
- Set to transient for restart since we do want the DeviceLink to terminate and get cleared out of the child_spec state
jjcarstens
reviewed
Jan 16, 2024
jjcarstens
reviewed
Jan 16, 2024
oestrich
force-pushed
the
device-link-supervision-changes
branch
2 times, most recently
from
816a512 to
9122c1a
Compare
jjcarstens
approved these changes
Jan 16, 2024
- Partition supervisor for the DynamicSupervisor, with thousands of devices connected the single DynamicSupervisor could get overloaded, partition it to help reduce processing changing state quickly - Start a DeviceLink with the ID only, to help reduce state inside the supervisor, only store the device's ID in the supervisor state (since it's part of the child_spec that's stored in the supervisor state) - Remove the supervisor module to simplify, put the one function that matters in the DeviceLink module directly - Set to transient for restart since we do want the DeviceLink to terminate and get cleared out of the child_spec state
oestrich
force-pushed
the
device-link-supervision-changes
branch
from
9122c1a to
7204eb4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.