Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement comprehensive tests #1

Closed
5 tasks done
nerdyman opened this issue Sep 29, 2019 · 0 comments
Closed
5 tasks done

Implement comprehensive tests #1

nerdyman opened this issue Sep 29, 2019 · 0 comments

Comments

@nerdyman
Copy link
Owner

nerdyman commented Sep 29, 2019

Implement comprehensive automated tests for the entire lib.

ReactCompareSlider

  • Ensure clip-path value matches expected output (currently only testing for clip)
  • Ensure onPositionChange value matches expected output
  • Ensure portrait orientation matches expected position
  • Ensure custom handle is rendered in DOM

ReactCompareSliderImage

  • Ensure fallback is used when object-fit is not supported
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant