Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid using Lazy for metrics #4501

Closed
skyzh opened this issue Jun 13, 2023 · 3 comments
Closed

avoid using Lazy for metrics #4501

skyzh opened this issue Jun 13, 2023 · 3 comments
Labels
c/storage/pageserver Component: storage: pageserver t/bug Issue Type: Bug

Comments

@skyzh
Copy link
Member

skyzh commented Jun 13, 2023

Steps to reproduce

Currently, we are using Lazy for all metrics, but if we do not access that metric, it will not appear in the exporter.

Expected result

Actual result

Environment

Logs, links

@skyzh skyzh added t/bug Issue Type: Bug c/storage/pageserver Component: storage: pageserver labels Jun 13, 2023
@skyzh
Copy link
Member Author

skyzh commented Jun 29, 2023

Given we will need to pass a global object everywhere if we remove Lazy, this is not an optimal way to fix it. Currently we are solving this by adding access metrics in pre-initialize.

@skyzh skyzh closed this as not planned Won't fix, can't repro, duplicate, stale Jun 29, 2023
@skyzh
Copy link
Member Author

skyzh commented Jun 29, 2023

The intention of this issue is that there is a test case that checks if a metrics is available when a tenant is attached and removed when a tenant is detached. For page cache metrics, it is hard to have page hit in tests and therefore it is not available immediately when a tenant is created.

@skyzh
Copy link
Member Author

skyzh commented Jul 26, 2023

now tracked here #4813

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c/storage/pageserver Component: storage: pageserver t/bug Issue Type: Bug
Projects
None yet
Development

No branches or pull requests

1 participant