WIP Test xid wraparound #403
Draft
+158
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lubennikovaav
force-pushed
the
test_xid_wraparound
branch
4 times, most recently
from
78b0248 to
dbe96bd
Compare
lubennikovaav
force-pushed
the
test_xid_wraparound
branch
2 times, most recently
from
ea0b421 to
3b60b87
Compare
- Advance next_xid only when incoming xlog record has one. - Advance next_xid by one. Remove XID_CHECKPOINT_INTERVAL.
lubennikovaav
force-pushed
the
test_xid_wraparound
branch
from
3b60b87 to
01e2e88
Compare
Have you seen postgres/postgres@74cf7d46? |
|
@lubennikovaav so what with that? should we commit it or close it? |
|
As discussed moving to draft. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test uses test_consume_xids() and takes about 15min to complete.
Another way to test xid wraparound is to use
pg_resetwal -x, but it turned out to be too hacky and hard to debug. And also it doesn't test clog truncation.The commit also contains a few fixes to
update_next_xid()function to restore nextXid properly.