Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compute_ctl: sync-safekeepers on shutdown must run after postgres exits. #11022

Open
arssher opened this issue Feb 27, 2025 · 0 comments
Open

compute_ctl: sync-safekeepers on shutdown must run after postgres exits. #11022

arssher opened this issue Feb 27, 2025 · 0 comments
Labels
c/compute Component: compute, excluding postgres itself

Comments

@arssher
Copy link
Contributor

arssher commented Feb 27, 2025

If start_postgres fails with error!("could not start the compute node: {:#}", err); it returns None as child handle, which makes wait_postgres do nothing, which then starts sync-safekeepers in cleanup_after_postgres_exit before postgres exited, leading to spurious fighting over terms.

ref https://neondb.slack.com/archives/C03H1K0PGKH/p1740668117244159?thread_ts=1740665903.645719&cid=C03H1K0PGKH
@arssher arssher added the c/compute Component: compute, excluding postgres itself label Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c/compute Component: compute, excluding postgres itself
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@arssher