Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage controller: "home" scheduler stats become stale when changing tenant's preferred AZ #10493

Open
jcsp opened this issue Jan 23, 2025 · 0 comments
Assignees
Labels
c/storage/controller Component: Storage Controller t/bug Issue Type: Bug triaged bugs that were already triaged

Comments

@jcsp
Copy link
Collaborator

jcsp commented Jan 23, 2025

SchedulerNode holds counts of how many shards are scheduled onto the node as their home location, i.e. the tenant's preferred AZ matches the node's preferred AZ. This count is used to guide scheduling of newly created shards.

These stats become inaccurate when we modify the preferred AZ of a tenant manually. There needs to be some logic in TenantShard.set_preferred_az to adjust them.

This is a mild issue -- it only happens when we do manual intervention, and it only makes scheduling of new shards a bit less optimal (and the chart of home location counts a bit confusing).

@jcsp jcsp added c/storage/controller Component: Storage Controller t/bug Issue Type: Bug labels Jan 23, 2025
@jcsp jcsp self-assigned this Jan 28, 2025
@jcsp jcsp added the triaged bugs that were already triaged label Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c/storage/controller Component: Storage Controller t/bug Issue Type: Bug triaged bugs that were already triaged
Projects
None yet
Development

No branches or pull requests

1 participant