From 36fee50f4d376f0f665a2f005b0ab4b122bba323 Mon Sep 17 00:00:00 2001 From: Joonas Koivunen Date: Thu, 1 Jun 2023 20:12:07 +0300 Subject: [PATCH] compute_ctl: enable tracing panic hook (#4375) compute_ctl can panic, but `tracing` is used for logging. panic stderr output can interleave with messages from normal logging. The fix is to use the established way (pageserver, safekeeper, storage_broker) of using `tracing` to report panics. --- compute_tools/src/logger.rs | 2 ++ 1 file changed, 2 insertions(+) diff --git a/compute_tools/src/logger.rs b/compute_tools/src/logger.rs index 1b5cf647b0b8..f6fc88296830 100644 --- a/compute_tools/src/logger.rs +++ b/compute_tools/src/logger.rs @@ -33,5 +33,7 @@ pub fn init_tracing_and_logging(default_log_level: &str) -> anyhow::Result<()> { .init(); tracing::info!("logging and tracing started"); + utils::logging::replace_panic_hook_with_tracing_panic_hook().forget(); + Ok(()) }