From cff9027755696b300a29d6465167b4b6dd9edc0f Mon Sep 17 00:00:00 2001
From: Giuseppe Villani <giuseppe.villani@larus-ba.it>
Date: Thu, 15 Dec 2022 15:11:07 +0100
Subject: [PATCH] fix cluster test

---
 .../trigger/TriggerClusterRoutingTest.java    | 33 +++----------------
 1 file changed, 5 insertions(+), 28 deletions(-)

diff --git a/core/src/test/java/apoc/trigger/TriggerClusterRoutingTest.java b/core/src/test/java/apoc/trigger/TriggerClusterRoutingTest.java
index 40814151c..c9fb68d56 100644
--- a/core/src/test/java/apoc/trigger/TriggerClusterRoutingTest.java
+++ b/core/src/test/java/apoc/trigger/TriggerClusterRoutingTest.java
@@ -44,10 +44,6 @@ public static void bringDownCluster() {
             cluster.close();
         }
     }
-
-    // TODO: making sure that a session against "system" can install triggers
-
-    // TODO: making sure that a session against "system" can drop triggers
     
     // TODO: fabric tests
 
@@ -80,38 +76,19 @@ private static void triggerInSysWriterMemberCommon(String query, String triggerN
         assertEquals(4, members.size());
         int errorCounter = 0;
         for (Neo4jContainerExtension container: members) {
-            // we skip READ_REPLICA members
-            final String readReplica = TestcontainersCausalCluster.ClusterInstanceType.READ_REPLICA.toString();
             final Driver driver = container.getDriver();
-            if (readReplica.equals(container.getEnvMap().get("NEO4J_dbms_mode")) || driver == null) {
-                continue;
-            }
             Session session = driver.session(SessionConfig.forDatabase(dbName));
-            final String address = container.getEnvMap().get("NEO4J_dbms_connector_bolt_advertised__address");
             final String name = UUID.randomUUID().toString();
-            if (dbName.equals(SYSTEM_DATABASE_NAME) && dbIsWriter(session, dbName, address)) {
+            try {
                 testCall( session, query,
                         Map.of("name", name),
                         row -> assertEquals(name, row.get("name")) );
-            } else {
-                try {
-                    testCall( session, query,
-                            Map.of("name", name),
-                            row -> assertEquals(name, row.get("name")) );
-                } catch (Exception e) {
-                    errorCounter++;
-                    String errorMsg = e.getMessage();
-                    assertTrue("The actual message is: " + errorMsg, errorMsg.contains(triggerNotRoutedError));
-                }
+            } catch (Exception e) {
+                errorCounter++;
+                String errorMsg = e.getMessage();
+                assertTrue("The actual message is: " + errorMsg, errorMsg.contains(triggerNotRoutedError));
             }
         }
         assertEquals(1, errorCounter);
     }
-
-    private static boolean dbIsWriter(Session session, String dbName, String address) {
-        return session.run( "SHOW DATABASE $dbName WHERE address = $address", 
-                        Map.of("dbName", dbName, "address", address) )
-                .single().get("writer")
-                .asBoolean();
-    }
 }