Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve devcontainer to dockerfile #3255

Closed
vncoelho opened this issue May 21, 2024 · 2 comments · Fixed by #3259
Closed

Improve devcontainer to dockerfile #3255

vncoelho opened this issue May 21, 2024 · 2 comments · Fixed by #3259

Comments

@vncoelho
Copy link
Member

According to the standard in https://containers.dev/guide/dockerfile, it will be better for us to move to a specific dockerfile instead of "image": "mcr.microsoft.com/devcontainers/base:ubuntu"

This dockerfile will also be used for the UTs for neo-cli

@vncoelho
Copy link
Member Author

I just tested here and they are different.
The dockerfile for devcontainer would need to be different because there are limited images available there.

@vncoelho
Copy link
Member Author

in fact it will be necessary because of libleveldb-dev to neo-modules

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant