Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PointerSymbol is handling precedence incorrectly #267

Closed
jgosmann opened this issue Sep 25, 2020 · 0 comments · Fixed by #268
Closed

PointerSymbol is handling precedence incorrectly #267

jgosmann opened this issue Sep 25, 2020 · 0 comments · Fixed by #268
Assignees
@jgosmann
Labels
bug
Milestone
1.1.1

Comments

@jgosmann
Copy link
Collaborator 

scene = spa.sym.RED * spa.sym.CIRCLE + spa.sym.BLUE * spa.sym.SQUARE
scene * ~spa.sym.SQUARE

produces

PointerSymbol('RED*CIRCLE+BLUE*SQUARE*~SQUARE', _TAnyVocab('TAnyVocab'))

but should produce

PointerSymbol('(RED*CIRCLE+BLUE*SQUARE)*~SQUARE', _TAnyVocab('TAnyVocab'))
@jgosmann jgosmann added the bug label Sep 25, 2020
@jgosmann jgosmann added this to the 1.1.1 milestone Sep 25, 2020
@jgosmann jgosmann self-assigned this Sep 28, 2020
jgosmann added a commit that referenced this issue Sep 30, 2020
@jgosmann
Build expression trees in PointerSymbol
86a98d8 
This enables correct handling of precedence, e.g.

s = sym.A + sym.B
s * sym.C

will be correctly handled as (sym.A + sym.B) * sym.C instead of
sym.A + (sym.B * sym.C).

Fixes #267.
@jgosmann jgosmann mentioned this issue Oct 2, 2020
Merged
4 tasks
jgosmann added a commit that referenced this issue Oct 2, 2020
@jgosmann
Build expression trees in PointerSymbol
7627ee3 
This enables correct handling of precedence, e.g.

s = sym.A + sym.B
s * sym.C

will be correctly handled as (sym.A + sym.B) * sym.C instead of
sym.A + (sym.B * sym.C).

Fixes #267.
jgosmann added a commit that referenced this issue Oct 3, 2020
@jgosmann
Build expression trees in PointerSymbol
3a27fc5 
This enables correct handling of precedence, e.g.

s = sym.A + sym.B
s * sym.C

will be correctly handled as (sym.A + sym.B) * sym.C instead of
sym.A + (sym.B * sym.C).

Fixes #267.
jgosmann added a commit that referenced this issue Oct 7, 2020
@jgosmann
Build expression trees in PointerSymbol
7fedff0 
This enables correct handling of precedence, e.g.

s = sym.A + sym.B
s * sym.C

will be correctly handled as (sym.A + sym.B) * sym.C instead of
sym.A + (sym.B * sym.C).

Fixes #267.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jgosmann jgosmann

Labels
bug
Milestone
1.1.1
Development

Successfully merging a pull request may close this issue.

Fix precedence with PointerSymbols nengo/nengo-spa
1 participant
@jgosmann