Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow language switching on the fly between available translations #21

Open
pqhf5kd opened this issue Mar 8, 2021 · 3 comments
Open
Labels
enhancement New feature or request

Comments

@pqhf5kd
Copy link
Collaborator

pqhf5kd commented Mar 8, 2021

I see that there is an English value file
https://github.com/nekromoff/bicycle-master-plan/blob/master/public/translations/en.js

But I can't see a way to switched to English on the map.

Have I missed it or is it not yet implemented?

@nekromoff
Copy link
Owner

Hello,
the default config/map.php (example) file contains ISO language code: 'language' => 'en',
https://github.com/nekromoff/bicycle-master-plan/blob/master/config/map.example.php

The language/translation is based on that config value.

@pqhf5kd
Copy link
Collaborator Author

pqhf5kd commented Mar 8, 2021

Are you planning on allowing users to switch between languages, independent of the site's config?

I would like to point foreigners and expats in Kosice, who don't speak Slovak, to 'Mapa cyklotrás' when they ask about what it's like to cycle here.

@nekromoff nekromoff changed the title English Translation Allow language switching on the fly between available translations Mar 8, 2021
@nekromoff nekromoff reopened this Mar 8, 2021
@nekromoff
Copy link
Owner

Thanks for the suggestion, it should be easy to implement.

@nekromoff nekromoff added the enhancement New feature or request label Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants