Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linking api is not compatible with RN #2507

Closed
1 task done
burakgormek opened this issue Apr 10, 2023 · 1 comment
Closed
1 task done

Linking api is not compatible with RN #2507

burakgormek opened this issue Apr 10, 2023 · 1 comment
Labels
Milestone

Comments

@burakgormek
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Describe the issue

Linking api not compatible with RN latest version(or before).

React Native v0.65 release note has:

  • Deprecate Linking.removeEventListener. Instead, call remove() on the subscription returned by Linking.addEventListener.

We should add remove() subscription method. Otherwise it will throw error on RNW.
I'm not sure if we still need to deprecate or remove removeEventListener after v0.19 publish.

Expected behavior

Compatible Linking api with RN.

Steps to reproduce

Open sandbox:
Click button.

Test case

https://codesandbox.io/s/priceless-darwin-3p033u

Additional comments

No response

@necolas
Copy link
Owner

necolas commented Apr 10, 2023

A PR for this can use the same approach as was used in AppState: https://github.com/necolas/react-native-web/blob/0.18.0/packages/react-native-web/src/exports/AppState/index.js

@necolas necolas added this to the 0.19.x milestone Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants