Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Balancer truffle tests into nightly test #3450

Closed
ilblackdragon opened this issue Oct 5, 2020 · 9 comments
Closed

Add Balancer truffle tests into nightly test #3450

ilblackdragon opened this issue Oct 5, 2020 · 9 comments
Assignees
Labels
A-EVM Area: Native EVM implementation and support A-testing Area: Unit testing / integration testing A-transaction-runtime Area: transaction runtime (transaction and receipts processing, state transition, etc)

Comments

@ilblackdragon
Copy link
Member

ilblackdragon commented Oct 5, 2020

We have running Balancer's tests here - ilblackdragon/balancer-core#1

We should run them in the nightly test to make sure that EVM + web3 provider continues to function.
Also later we can add more contracts / setups there.

@ilblackdragon ilblackdragon added A-testing Area: Unit testing / integration testing A-transaction-runtime Area: transaction runtime (transaction and receipts processing, state transition, etc) labels Oct 5, 2020
@ailisp ailisp added the A-EVM Area: Native EVM implementation and support label Oct 6, 2020
@ailisp
Copy link
Member

ailisp commented Nov 2, 2020

Status: Mike has about 9 test failed. I'm not even not able to get test running, stuck infinitely after create 4 testing accounts and before deploy evm contracts

@ailisp
Copy link
Member

ailisp commented Nov 12, 2020

@artob and @mikedotexe is going to look how to make all truffle tests pass. Please let me know when you success so i can make a script and add to nightly

@artob
Copy link
Contributor

artob commented Nov 18, 2020

@ailisp The CryptoZombies tests fixed in #3624. I'm working on adding more tests. I believe @mikedotexe is working with the Balancer tests.

@artob
Copy link
Contributor

artob commented Dec 1, 2020

FYI, as @mikedotexe was occupied elsewhere, I'm working on fixing the Balancer tests in #3665.

@artob
Copy link
Contributor

artob commented Dec 4, 2020

All right, @mikedotexe and I have collaborated to investigate and fix the issues with the Balancer test suite, and all tests now pass (#3665). Our customizations to the test suite are pending upstream submission at near/balancer-core#1.

@ailisp Will you have time soon to add the Balancer tests to the nightly test, or should @mikedotexe or I take this over?

@alexauroradev alexauroradev changed the title [EVM] Add Balancer truffle tests into nightly test Add Balancer truffle tests into nightly test Dec 4, 2020
@ailisp
Copy link
Member

ailisp commented Dec 4, 2020

@artob Just about to asking this! I can add it. After following #3665, is current way of running it by:

@artob
Copy link
Contributor

artob commented Dec 7, 2020

@ailisp Yes, that's pretty much it. However, given #3665 (comment), you probably want to use @mikedotexe's package-lock.json which is known to work. If you just do an npm install from scratch, you are likely to see the same problems that I did. I'll send the file over privately.

@artob
Copy link
Contributor

artob commented Dec 17, 2020

@ailisp Do you still plan to tackle this task, or should we reassign it?

@artob
Copy link
Contributor

artob commented Jan 14, 2021

Fixed in #3763.

@artob artob closed this as completed Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-EVM Area: Native EVM implementation and support A-testing Area: Unit testing / integration testing A-transaction-runtime Area: transaction runtime (transaction and receipts processing, state transition, etc)
Projects
None yet
Development

No branches or pull requests

3 participants