-
Notifications
You must be signed in to change notification settings - Fork 687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Balancer truffle tests into nightly test #3450
Comments
Status: Mike has about 9 test failed. I'm not even not able to get test running, stuck infinitely after create 4 testing accounts and before deploy evm contracts |
@artob and @mikedotexe is going to look how to make all truffle tests pass. Please let me know when you success so i can make a script and add to nightly |
@ailisp The CryptoZombies tests fixed in #3624. I'm working on adding more tests. I believe @mikedotexe is working with the Balancer tests. |
FYI, as @mikedotexe was occupied elsewhere, I'm working on fixing the Balancer tests in #3665. |
All right, @mikedotexe and I have collaborated to investigate and fix the issues with the Balancer test suite, and all tests now pass (#3665). Our customizations to the test suite are pending upstream submission at near/balancer-core#1. @ailisp Will you have time soon to add the Balancer tests to the nightly test, or should @mikedotexe or I take this over? |
@artob Just about to asking this! I can add it. After following #3665, is current way of running it by:
|
@ailisp Yes, that's pretty much it. However, given #3665 (comment), you probably want to use @mikedotexe's |
@ailisp Do you still plan to tackle this task, or should we reassign it? |
Fixed in #3763. |
We have running Balancer's tests here - ilblackdragon/balancer-core#1
We should run them in the nightly test to make sure that EVM + web3 provider continues to function.
Also later we can add more contracts / setups there.
The text was updated successfully, but these errors were encountered: