Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MISRA C++ 2023 rule 7.0.4 "The operands of bitwise operators and shift operators shall be appropriate" #630

Closed
mohammedRafeeque opened this issue Jun 14, 2024 · 2 comments
Assignees
Labels
bug Something isn't working c++ C++ language generator
Milestone

Comments

@mohammedRafeeque
Copy link

Zserio version and language
Zserio: latest from master
Commit date: 6 days ago (6/4/2024 7:12:28 PM)
Commit hash: b8cc6c0

Describe the bug
2 Misra warnings are getting reported for rule MISRACPP2023-7_0_4-a

1 & 2 return calcHashCodeFirstTerm(seedValue) + static_cast<uint32_t>(unsignedValue ^ (unsignedValue >> 32U));

<style> </style>
SNo Rule Severity Message Filename Linenumber
1658 MISRACPP2023-7_0_4-a 2 The right-hand-side operand of bitwise operator '^' should be unsigned zserio_runtime/zserio/HashCodeUtil.h 62
1657 MISRACPP2023-7_0_4-a 2 The left-hand-side operand of bitwise operator '^' should be unsigned /zserio_runtime/zserio/HashCodeUtil.h 62

Please check possibility of fixing the same.

Steps to reproduce the behavior:
SCA run using MISRA 2023 configuration.

Expected behavior
No SCA warnings for MISRA 2023 ruleset

Additional context
N.A

@Roland-Homeier @mikir FYI.

@mohammedRafeeque mohammedRafeeque added the bug Something isn't working label Jun 14, 2024
@mikir mikir added the c++ C++ language generator label Jun 14, 2024
@mikir mikir added this to the 2.15 milestone Jun 14, 2024
@mikir mikir changed the title Fix for MISRA C++ 2023 rule MISRACPP2023-7_0_4-a The left-hand-side and right hand side operand of bitwise operator '^' should be unsigned Fix MISRA C++ 2023 rule 7.0.4 "The operands of bitwise operators and shift operators shall be appropriate" Jun 14, 2024
@mohammedRafeeque
Copy link
Author

This 2 warnings are no more getting reported in the latest main and latest run.

We can close this ticket.

@Mi-La
Copy link
Contributor

Mi-La commented Aug 9, 2024

We have rule S874 enabled, it partially checks the 7.0.4 Misra C++ 2023 rule. Currently it catches nothing.

@Mi-La Mi-La closed this as completed Aug 9, 2024
@Mi-La Mi-La self-assigned this Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working c++ C++ language generator
Projects
None yet
Development

No branches or pull requests

3 participants