[#628] Fix issue in StringConvertUtil.h caught by MISRA 2023 rule 7.0.3

mikir · mikir · commit dbe4083093a4 · 2024-08-19T14:29:21.000+02:00
diff --git a/compiler/extensions/cpp/runtime/src/zserio/StringConvertUtil.h b/compiler/extensions/cpp/runtime/src/zserio/StringConvertUtil.h
@@ -33,7 +33,7 @@ const char* convertIntToString(std::array<char, 24>& buffer, T value, bool isNeg
             "8081828384858687888990919293949596979899"};
 
     auto bufferEnd = buffer.end();
-    *(--bufferEnd) = 0; // always terminate with '\0'
+    *(--bufferEnd) = '\0'; // always terminate with '\0'
 
     while (value >= 100)
     {

Original file line number	Diff line number	Diff line change
`@@ -33,7 +33,7 @@ const char* convertIntToString(std::array<char, 24>& buffer, T value, bool isNeg`
`33`	`33`	`"8081828384858687888990919293949596979899"};`
`34`	`34`
`35`	`35`	`auto bufferEnd = buffer.end();`
`36`		`- *(--bufferEnd) = 0; // always terminate with '\0'`
	`36`	`+ *(--bufferEnd) = '\0'; // always terminate with '\0'`
`37`	`37`
`38`	`38`	`while (value >= 100)`
`39`	`39`	`{`