[#374] Remove initialize_offsets calling from pubsub/service/sql table

Author: mikir

compiler/extensions/python/freemarker/Pubsub.py.ftl

@@ -113,7 +113,6 @@ class ${name}:
 
     def _publish(self, topic: str, message: typing.Any, context: typing.Any) -> None:
         writer = zserio.BitStreamWriter()
-        message.initialize_offsets(writer.bitposition)
         message.write(writer)
         self._pubsub.publish(topic, writer.byte_array, context)
 </#if>

compiler/extensions/python/freemarker/SqlTable.py.ftl

@@ -365,7 +365,6 @@ class ${name}:
         ${field.snakeCaseName}_ = row_in_list[${field?index}]
         if isinstance(${field.snakeCaseName}_, ${field.typeInfo.typeFullName}):
             writer = zserio.BitStreamWriter()
-            ${field.snakeCaseName}_.initialize_offsets(writer.bitposition)
             ${field.snakeCaseName}_.write(writer)
             row_in_list[${field?index}] = writer.byte_array
 

compiler/extensions/python/runtime/src/zserio/service.py

@@ -33,7 +33,6 @@ def byte_array(self) -> bytes:
 
         if not self._is_byte_array_initialized:
             writer = BitStreamWriter()
-            self._zserio_object.initialize_offsets(writer.bitposition)
             self._zserio_object.write(writer)
             self._byte_array = writer.byte_array
             self._is_byte_array_initialized = True

compiler/extensions/python/runtime/tests/test_service.py

@@ -7,7 +7,6 @@ def test_service_data(self):
         class ZserioObject:
             def __init__(self, value):
                 self._value = value
-                self._offsets_initialized = False
 
             def __eq__(self, other):
                 return self._value == other._value
@@ -16,14 +15,8 @@ def __eq__(self, other):
             def bitsizeof(_bitposition):
                 return 31 # to make an unaligned type
 
-            def initialize_offsets(self, bitposition: int) -> int:
-                self._offsets_initialized = True
-                return bitposition + ZserioObject.bitsizeof(bitposition)
-
             def write(self, writer):
-                # don't write anything if offsets are not initialized to force test failure
-                if self._offsets_initialized:
-                    writer.write_bits(self._value, self.bitsizeof(0))
+                writer.write_bits(self._value, self.bitsizeof(0))
 
         zserio_object = ZserioObject(0xABCD)
         service_data = ServiceData(zserio_object)

test/language/service_types/python/ComplexTypesServiceTest.py

@@ -114,6 +114,7 @@ def testRgbToCmyk(self):
 
         requestData = self.api.RequestData(self.api.ColorModel.RGB, offsets, data)
         request = self.api.Request(self.api.ColorModel.RGB, requestData)
+        request.initialize_offsets(0)
 
         self.assertEqual(length, self.client.get_length(request).length)
 
@@ -141,6 +142,7 @@ def testCmykToRgb(self):
 
         requestData = self.api.RequestData(self.api.ColorModel.CMYK, offsets, data)
         request = self.api.Request(self.api.ColorModel.CMYK, requestData)
+        request.initialize_offsets(0)
 
         self.assertEqual(length, self.client.get_length(request).length)
 

test/language/sql_tables/python/ComplexTableTest.py

@@ -102,6 +102,7 @@ def _createComplexTableRows(self):
     def _createComplexTableRow(self, blobId, name):
         values = [blobId for i in range(self.COMPLEX_TABLE_COUNT)]
         blob = self.api.complex_table.TestBlob(len(values), 0, values, True)
+        blob.initialize_offsets(0)
 
         return (blobId, zserio.limits.INT64_MAX, name, True, 9.9, 5.5, 0x34,
                 self.api.complex_table.TestEnum.RED, blob)