Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.editorconfig override path #28

Closed
mezpahlan opened this issue Jan 8, 2021 · 6 comments
Closed

.editorconfig override path #28

mezpahlan opened this issue Jan 8, 2021 · 6 comments
Labels
bug Something isn't working
Milestone

Comments

@mezpahlan
Copy link

Hi there

Great plugin, our team loves using it!

I recently upgraded to 0.7.0 and started to notice that previously acceptable kotlin files were now marked with ktlint errors. Specifically the line length error. On closer inspection it seemed to be reporting the line length and import ordering as the default ktlint values and not the values that we have set in our .editorconfig file.

I don't remember having to manually configure the editorconfig file in previous versions of the plugin but as a workaround I added the folder that contains this file to the .editorconfig override path in the settings menu and that worked.

The location of our editorconfig hasn't changed ever and has always been in the root of the project.

android
  | app
    | build.gradle
  | settings.gradle
  | gradlew
  | build.gradle
  | .editorconfig

I'm running Windows if that matters.

@phanimahesh
Copy link

Can confirm that the editor config at project root is not being picked up. Setting override works, though. Multi module maven project on linux.

@nbadal
Copy link
Owner

nbadal commented Jan 23, 2021

Thanks for flagging this! I'll take a look today 😄

@phanimahesh by chance - did this issue also arise with 0.7.0 specifically for you? Or has it always been the case?

@nbadal nbadal added the bug Something isn't working label Jan 23, 2021
@nbadal nbadal added this to the 0.7.1 milestone Jan 23, 2021
@nbadal
Copy link
Owner

nbadal commented Jan 23, 2021

Fix added to 0.7.1 😀

@nbadal nbadal closed this as completed Jan 23, 2021
@phanimahesh
Copy link

I installed the plugin recently and discovered the issue. Not sure if it always existed or was a regression.

@nbadal
Copy link
Owner

nbadal commented Jan 24, 2021

Great, just wanted to make sure it was the same cause! 0.7.1 should be rolling out shortly

@mezpahlan
Copy link
Author

Hi @nbadal mega thanks for the quick patch! I received the update today and tested it out by removing the workaround I mentioned above. Seemed fine for the day of use I had. I didn't restart the IDE in that time but...... I'm assuming that doesn't matter.

Cheers again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants